Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Sapphire/FlexibleDiagramNodeShapes
This page tracks ongoing issues and discussions pertaining to Bug 383924.
Issues raised from the UI review with our usability expert:
1. Combo cell editor should be used when direct editing an enum property Bug 404500 resolved
2. Remove "direct edit" context menu Bug 404503 resolved
3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu Bug 404499 resolved
4. [Sql Schema Editor Sample] Add column action in table node's floating palette doesn't work Bug 404501 resolved
Miscellaneous issues:
1. Direct editing a newly created node doesn't hide the node label.
2. Select a node that can be resized (ex. sqlschema.xml) and make the node larger.
a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not b. Continue to add columns, node does not expand to fit all the newly added columns c. Edit the column type which is a combo and it extends outside the node, not utilize the available space.
3.Reorder column (ex. sqlschema.xml) and column inserted in different location than the visual aid (one column below). Works if moving to a column above. Also the visual aid feedback is a few pixel too big.
4. Drag/drop does not work when moving to the last item - same bug as 3, didn't completely fix.
5.Drag/drop feedback should match orange guide lines.
6. UML test case - line figure extends to the right edge, ignored specified margin.
7.Shape Factory always places its children in the 0th index position.
8. "Show in source" context button not placed correctly in UML text case.
9. Shape factory with no separator NPE.
10. Shape factory -> Case -> Text, note editing not allowed, manual editing in source code results in NPE
11.Shape factory -> Case -> Rectangle -> Rectangle -> Validation Marker not displayed.
Workaround: Shape factory -> Case -> Rectangle -> Validation Marker
12. sqlschema.xml -> edit the <type>, and type in an invalid text "aaa". Notice the text is still <type>. Type in another invalid text "bbb". Now view the error message, "aaa" is not a valid column type, and notice the error message did not update.
12.b atchitecture.xml -> The error message is not shown in the assist dialog.
13. uml.xml -> extra spacing at the end (when the top text margin is 5)
14. uml.mxl -> visible-when on a Rectangle that contains ShapeFactory. First add -> child not added Subsequent add -> ERROR : Figure is not a child java.lang.IllegalArgumentException: Figure is not a child Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=63e73547f6bc78a9ec494028a7b39ca8ca45a682
15. sqlschema.xml -> add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.
This is not an issue. The sql schema editor's column layout has the column name field left aligned but doesn't expand. The column type field is right aligned and does expand to take up the extra space. So even if the name column appears to have extra space, it is the column type field that has the extra space.
16. Need a test case for nested shape factories.
17. sqlschema.xml -> add a new column to a table in source editor, the new column is always displayed as the last column in the diagram editor even if the new column is inserted in the middle of the table in the source editor.
18. Shape factory -> Case -> Text, the text is editable, selectable and movable, but the selection border is not displayed.
19. Added 3 nested Rectangle - each with a different color border and only one of the border is shown. Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4949e1c7ddf768ff2243fb20a74fa362aa6f075
20. In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case.
21. Alignment for shapes is only applied when "expand" bit is turned on, making text with default alignment which is center-aligned appear to be left-aligned when there is extra space for the text shape. It's also inconsistent with the cell editor locator for the text figure when direct-editing.
22. Click away from the validation marker pop up results NPE
23. The behavior of the floating toolbar feels odd in the presence of internal selection. Let's make the floating toolbar work off the selection rather than mouse hover.
24. Impossible to multi-select and delete internal shapes using the context menu.
Resovled http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=0a4382698cc60c3aab461110caee898024a114ef
Verified by Konstantin
25. Shift+Click behaves the same as Ctrl+Click when clicking on internal shapes instead of the expected behavior of selecting a range of shapes.
26. Shape factory selection border inset should support negative numbers to expand selection border beyond shape bounds.
27. sqlschema.xml drag & drop column results in ClassCastException.
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=e5a8ffda80ffc0032a0d0b817911faab8a2cb9c8
Verified by Konstantin
28. When in direct edit mode, pressing a tab should move editing to the next field.
29. NPE at DiagramDeleteActionHandler.java:100 sometimes when deleting shapes in UML editor sample.
30. Default text color should be black. Use "black" rather than "#000000".
32. Need to be able to specify Properties View Contribution for a shape factory case. Currently, can only be done at node level.
32. Need to be able to control selection presentation for the node, similar to what's possible for a shape factory case. Additionally, the background of the selection should be controllable in both cases. The default should probably be no background.
33. Delete all bendpoints action shows up when selected multiple shapes.
34. In the layout, cell sizes (min, max and preferred) should be after margins are applied, rather than before.
35. Spacer part is needed. This part should be treated as a transparent elastic, capable of size from 0 to infinity. All sizing-related layout constraints should apply. Besides the layout constraint, the only user-configurable property should be visible-when.
36. Validation marker part should handle lack of a validation problem by making the part invisible. Override SapphirePart.initVisibleWhenFunction().
37. Image part should handle lack of an image by making the part invisible. Override SapphirePart.invisibleWhenFunction to augment this implicit constraint to whatever the user may have specified.
38. ShapeFactoryPart does not implement computeValidation. It needs to rollup the validation result for the parts that it creates/manages.