Sapphire/FlexibleDiagramNodeShapes

This page tracks ongoing issues and discussions pertaining to Bug 383924.

Issues raised from the UI review with our usability expert:

1. Combo cell editor should be used when direct editing an enum property Bug 404500 resolved

2. Remove "direct edit" context menu Bug 404503 resolved

3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu Bug 404499 resolved

4. [Sql Schema Editor Sample] Add column action in table node's floating palette doesn't work Bug 404501 resolved

Miscellaneous issues:

1. Direct editing a newly created node doesn't hide the node label. resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4ccb7d0064a970c96dbdf3dc23676e2155bdf79

2. Select a node that can be resized (ex. sqlschema.xml) and make the node larger.

  a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not
  b. Continue to add columns, node does not expand to fit all the newly added columns
  c. Edit the column type which is a combo and it extends outside the node, not utilize the available space.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d96f45b960d95b7ccf712b589612ce5c39bc8f43

3. Reorder column (ex. sqlschema.xml) and column inserted in different location than the visual aid (one column below). Works if moving to a column above. Also the visual aid feedback is a few pixel too big. Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bcf33857fb440acb7895a17f3d5f74b6e1957c1f

4. Drag/drop does not work when moving to the last item - same bug as 3, didn't completely fix. Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=7459594a669c7dd7790d61c891cd30fe042d5662

5. Drag/drop feedback should match orange guide lines Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5ed5db1ff475879c2f8a9e8db4f1e5c9cd1b0a49

6. UML test case - line figure extends to the right edge, ignored specified margin. Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bb35b4d334ada840adf960f3c06fd4fecfefaca7

7. Shape Factory always places its children in the 0th index position Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=85a274836593b352e977e066e5e38f76ec3d1530

8. "Show in source" context button not placed correctly in UML text case. Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=68fe36f36c89455dc59431ae2caec035bdab4037

9. Shape factory with no separator NPE.

10. Shape factory -> Case -> Text, note editing not allowed, manual editing in source code results in NPE

 Workaround: Put Text inside a Rectangle

11. Shape factory -> Case -> Rectangle -> Rectangle -> Validation Marker not displayed.

 Workaround: Shape factory -> Case -> Rectangle -> Validation Marker