Skip to main content

Notice: This Wiki is now read only and edits are no longer possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

Difference between revisions of "Sapphire/FlexibleDiagramNodeShapes"

Line 75: Line 75:
 
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=879fbe5c5d4588472387ba089306b0423d34f120  
 
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=879fbe5c5d4588472387ba089306b0423d34f120  
  
14. uml.mxl -> visible-when on a Rectangle that contains ShapeFactory. First add -> child not added Subsequent add -> ERROR : Figure is not a child java.lang.IllegalArgumentException: Figure is not a child  
+
14. <strike>uml.mxl -&gt; visible-when on a Rectangle that contains ShapeFactory. First add -&gt; child not added Subsequent add -&gt; ERROR&nbsp;: Figure is not a child java.lang.IllegalArgumentException: Figure is not a child </strike>
http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=63e73547f6bc78a9ec494028a7b39ca8ca45a682
+
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=63e73547f6bc78a9ec494028a7b39ca8ca45a682
  
 
<br> <strike>15. sqlschema.xml -&gt; add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.</strike>  
 
<br> <strike>15. sqlschema.xml -&gt; add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.</strike>  
Line 92: Line 92:
 
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d6cae2475ac1a9608e6738e70a8102736c30d64a  
 
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d6cae2475ac1a9608e6738e70a8102736c30d64a  
  
19. Added 3 nested Rectangle - each with a different color border and only one of the border is shown.
+
19. <strike>Added 3 nested Rectangle - each with a different color border and only one of the border is shown.</strike>
http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4949e1c7ddf768ff2243fb20a74fa362aa6f075  
+
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4949e1c7ddf768ff2243fb20a74fa362aa6f075  
  
 
20. <strike>In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case. </strike>  
 
20. <strike>In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case. </strike>  

Revision as of 19:39, 11 July 2013

This page tracks ongoing issues and discussions pertaining to Bug 383924.

Issues raised from the UI review with our usability expert:

1. Combo cell editor should be used when direct editing an enum property Bug 404500 resolved

2. Remove "direct edit" context menu Bug 404503 resolved

3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu Bug 404499 resolved

4. [Sql Schema Editor Sample] Add column action in table node's floating palette doesn't work Bug 404501 resolved

Miscellaneous issues:

1. Direct editing a newly created node doesn't hide the node label.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4ccb7d0064a970c96dbdf3dc23676e2155bdf79

2. Select a node that can be resized (ex. sqlschema.xml) and make the node larger.

  a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not
b. Continue to add columns, node does not expand to fit all the newly added columns
c. Edit the column type which is a combo and it extends outside the node, not utilize the available space.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d96f45b960d95b7ccf712b589612ce5c39bc8f43

3.Reorder column (ex. sqlschema.xml) and column inserted in different location than the visual aid (one column below). Works if moving to a column above. Also the visual aid feedback is a few pixel too big.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bcf33857fb440acb7895a17f3d5f74b6e1957c1f

4. Drag/drop does not work when moving to the last item - same bug as 3, didn't completely fix.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=7459594a669c7dd7790d61c891cd30fe042d5662

5.Drag/drop feedback should match orange guide lines.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5ed5db1ff475879c2f8a9e8db4f1e5c9cd1b0a49

6. UML test case - line figure extends to the right edge, ignored specified margin.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bb35b4d334ada840adf960f3c06fd4fecfefaca7

7.Shape Factory always places its children in the 0th index position.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=85a274836593b352e977e066e5e38f76ec3d1530

8. "Show in source" context button not placed correctly in UML text case.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=68fe36f36c89455dc59431ae2caec035bdab4037

9. Shape factory with no separator NPE.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=e18f4d6e5e8e8897247707f037a19133efa27c35

10. Shape factory -> Case -> Text, note editing not allowed, manual editing in source code results in NPE

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=ea1d0a618962d0f152288624b513f7dea56db9f0

11.Shape factory -> Case -> Rectangle -> Rectangle -> Validation Marker not displayed.

 Workaround: Shape factory -> Case -> Rectangle -> Validation Marker

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=c542a7f75e653d2eb9edc97b7d982c4c82f2e071

12. sqlschema.xml -> edit the <type>, and type in an invalid text "aaa". Notice the text is still <type>. Type in another invalid text "bbb". Now view the error message, "aaa" is not a valid column type, and notice the error message did not update.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=dc56d000a915a5295b8959dc8047f6aff9a7c342

12.b atchitecture.xml -> The error message is not shown in the assist dialog.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=3bf509dbe1ee6b77d91878e9b410ab26cbad2dc9

13. uml.xml -> extra spacing at the end (when the top text margin is 5)

Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=879fbe5c5d4588472387ba089306b0423d34f120

14. uml.mxl -> visible-when on a Rectangle that contains ShapeFactory. First add -> child not added Subsequent add -> ERROR : Figure is not a child java.lang.IllegalArgumentException: Figure is not a child Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=63e73547f6bc78a9ec494028a7b39ca8ca45a682


15. sqlschema.xml -> add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.

This is not an issue. The sql schema editor's column layout has the column name field left aligned but doesn't expand. The column type field is right aligned and does expand to take up the extra space. So even if the name column appears to have extra space, it is the column type field that has the extra space.

16. Need a test case for nested shape factories.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=27b96267109590f0285799f149b609fcd1435077

17. sqlschema.xml -> add a new column to a table in source editor, the new column is always displayed as the last column in the diagram editor even if the new column is inserted in the middle of the table in the source editor.

18. Shape factory -> Case -> Text, the text is editable, selectable and movable, but the selection border is not displayed.

Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d6cae2475ac1a9608e6738e70a8102736c30d64a

19. Added 3 nested Rectangle - each with a different color border and only one of the border is shown. Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4949e1c7ddf768ff2243fb20a74fa362aa6f075

20. In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case.

Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=27b96267109590f0285799f149b609fcd1435077

21. Alignment for shapes is only applied when "expand" bit is turned on, making text with default alignment which is center-aligned appear to be left-aligned when there is extra space for the text shape. It's also inconsistent with the cell editor locator for the text figure when direct-editing.

Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5f3fd8c25e08d3d948f01e2180a45af18f6b2b2f

22. Click away from the validation marker pop up results NPE

Back to the top