Skip to main content

Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

JSDT/Confcalls/Minutes 20161115

JSDT Weekly Sync 15 Nov

Attendees: Angel, Victor, Ilya, Gorkem, Patrik

Status

Gorkem: create orbit recipe for the CC we're using, to be submitted Patrik is up to fix Bug 501790 - Invalid octal escape sequence (\8) causes IllegalArgumentException and to work on Bug 507518 - Nested brackets in template literals breaks the javascript formatter

Closure Compiler

Angel: Loking at the PR for CC. The CC change does not negatively affect the indexing Victor: CC is working pretty fast and we should use it. Some issue with CC when double clicking elements on Outline, like functionDeclaration There are some issues, already solved by Angel We should file a CQ and push the CC to JSDT

The search is using the same JavaElementModel used in outline. the JavaElementModel is looking at a NameRegion, to check if there is a name assigned to that region but we're getting the source range from the AST, and it should not matter whether there is a name or not (i.e. anonymous funciton)

Sparse ideas

A search match requires a IJavaScriptElement, (which has private constructors) and create its own IJavaScriptUnit used for search NodeConverter has issues, and function is a special case, as it has a series of parameters. Victor: idea, we could force the nodeconverter to have a range for each type of node.

EclipseCon

video available, https://www.youtube.com/watch?v=05UJn0_k-48 Patrik: I'm not happy of the quality, I was nervous, I'm up to create videos for the three demos

JSON Schema Validation

Issue with finding references.

Ilya: there is a Gerrit from August, from Angelo https://bugs.eclipse.org/bugs/show_bug.cgi?id=487465 The patch can't be reviewed, and we should give Angelo feedback. The issue: we could work on the debugger, but we couldn't have working examples ()

Back to the top