Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "JSDT/Confcalls/Minutes 20160412"
(Created page with "= JSDT/Confcalls/Minutes 20160412 = '''Attendees''' : Victor R., Patrik, Ilya, Ian, Chuck, Victor S, Gorkem, Orlando, Alina JSDT Quick references: [https://git.eclipse.org/...") |
|||
| Line 4: | Line 4: | ||
JSDT Quick references: [https://git.eclipse.org/r/#/q/project:jsdt/webtools.jsdt+is:pending JSDT pending changes (excl.SSE)], [https://bugs.eclipse.org/bugs/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=14136767&product=JSDT JSDT Open Bugs] | JSDT Quick references: [https://git.eclipse.org/r/#/q/project:jsdt/webtools.jsdt+is:pending JSDT pending changes (excl.SSE)], [https://bugs.eclipse.org/bugs/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=14136767&product=JSDT JSDT Open Bugs] | ||
| + | |||
| + | |||
| + | === Debugger === | ||
| + | Ilya: now debugger works in VFS, it is not clear yet how to add debug target. | ||
| + | |||
| + | Launch configuration: Adalberto and Ilya working together on this, meanwhile they fixed an Issue launching Nodejs config | ||
| + | |||
| + | The new image for the Node Launch: is in RH "design pipeline", better to ask to speed up the IP CQ process, to be completed before M7 | ||
| + | |||
| + | === Nodejs Runtime === | ||
| + | * Orlando: has a Gerrit review pending | ||
| + | |||
| + | === JSON Editor === | ||
| + | Alina has the fix ready: it will be possible inserting between nodes, and it will also a speed up avoiding the reload of the entire model when removing a node. | ||
| + | |||
| + | Please see details in bug comments, and keep in mind this is not a sync problem, but this is related to insertion of nodes and the outline is not aligned with the model. | ||
| + | |||
| + | Chuck: however, there is a workaround, consisting in refresh the outline. And this proofs the model is correct. | ||
| + | |||
| + | Victor: we should wait for the fix, and open an issue related to outline. there is one kind of element (array) that gives problems when displayed into the outline. Probably is related to a model event not properly triggered | ||
| + | |||
| + | A new RH teammate will look into JSON editor. She will assign to herself the bugs she want to work on. | ||
| + | |||
| + | Victor R. added icons for outline tree | ||
| + | |||
| + | === ES6 === | ||
| + | Gorkem: get the JSDT parser (Esprima) to work . There is a Gerrit review pending. It'll stay open for some time, for review, and It'll be merged. | ||
| + | |||
| + | For nested binary operations like ( 1 + ( 1 + 1 ) ) Esprima will have some limits we should look into | ||
| + | |||
| + | The keyworkd completion engine is in place, but you can't see it right now. You should wait for Ian work is committed to see the results from the correct code completion engine | ||
| + | |||
| + | Ian is working TDD-style and completing some last test before the code completion engine work as expected. | ||
| + | |||
| + | Shane: finished the work with template literals highlighting on JSDT editor (also nested) and Chromium debug editor (more simple). This is on master now. He is now working on exports in the outline view | ||
| + | |||
| + | Gorkem is to check ES6, and eventually add path entries using typescript or turn.js files. | ||
| + | |||
| + | Victor is looking at Gorkem changes and validation | ||
| + | |||
| + | === Other Issues === | ||
| + | Gorkem opened up a discussion about using SWTBot, nobody seems to have picked it up. probably we need to submit a request to WTP project | ||
| + | |||
| + | Victor R. we could also set up an instance for JSDT only, We should enable this on the HIPP (Hudson Instance Per Process) used by Gerrit. | ||
| + | |||
| + | It might be that the JSDT HIPP instance is the same HIPP that is used by WTP | ||
| + | |||
| + | Rob Stryker announced a change in Gerrit, as we used a kind of old version. | ||
| + | |||
| + | As you Type Validation fix depends on SSE. So this Fix works only for certain versions. | ||
| + | |||
| + | In some EPP packages the Nashorn classpath hooks stop working. there is some equinox work ongoing on this. Gorkem is to send some bug to EPP. | ||
| + | |||
| + | here is a link to an example bug sent to EPP: https://bugs.eclipse.org/bugs/show_bug.cgi?id=488781 | ||
| + | |||
| + | There is a Wiki page about Equinox Hook for Nashorn : https://wiki.eclipse.org/JSDT/Equinox_hook_for_Nashorn | ||
| + | |||
| + | Ilya: About JS and EPP packages. we'll have no Gulp and Grunt notes in M6. | ||
| + | |||
| + | Which main features are we going to push : JSDT (SDK) + Nodejs Bower, NPM, Gulp Grunt + Nodejs runtime (is part of core), and it depends on Chromium debug core | ||
| + | * VR: It is bad to be on core, because we did not want to depend on Chromium | ||
| + | |||
| + | * > can we depend optionally on Chromium | ||
| + | |||
| + | * IB: Actually we're doing two launches (..) | ||
| + | |||
| + | * VR: if the user has his verison of Nodejs, what will happen ? | ||
| + | |||
| + | * GE: probably CNFE | ||
| + | |||
| + | * IB: How are we supposed to handle this ? IMO not possible to make it optional | ||
| + | |||
| + | * VR: so, IB: it's like an API call VR: so CNFE is user has multiple instances. | ||
| + | |||
| + | * GE: there are other EPP which actually are including JSDT, i.e. BIRT | ||
| + | |||
| + | * BIRT probably doesn't care about Nodejs | ||
| + | |||
| + | * CB: it is not completely breaking things, but some features are not working. | ||
| + | |||
| + | * VR: suggest to make this dependency optional, as we might want to use our verison of Chrome | ||
| + | |||
| + | * IB: it could be done, but It'll require some duplication of code from ChDevTools, to Nodejs | ||
| + | |||
| + | * VR: in the end it just instantiate some classes and call some methods, isn'it ? | ||
| + | |||
| + | * IB: Our Chromium can depend on JSDT, but other Nodejs instances are not depending on Chromium! | ||
| + | |||
| + | * GE: For the users including Chromium in JSDT is the most beneficial. They don't actually see the implementation of the debugger, they'll just like better how it work. (..) It'll be beneficial for users. | ||
| + | |||
| + | * VR: our first intention was to not to make it required. | ||
| + | |||
| + | * GE, CB: other option is to make that an optional feature, and have the EPP package include that feature | ||
| + | |||
| + | * IB: Only launch parameter from Ch are used in NodeLaunchConf. So we can remove the dependency and Just copy the Configuration. | ||
| + | |||
| + | * VR: it could be a problem in future, when changing the params, (GE ) despite we're doing it actually most of the times, in many Eclipse projects. | ||
| + | |||
| + | * VR: CB should include Chromium in JEE (CB)Ok | ||
| + | |||
| + | * CB: Is going to take care of the EPP Packages, and | ||
| + | |||
| + | * IB: https://bugs.eclipse.org/bugs/show_bug.cgi?id=491528 | ||
| + | |||
| + | === API === | ||
| + | Patrik: fixed some @since, and found some issues with project. dependencies, versions | ||
| + | * VR: indeed Rob Stryker reported some issue related to wtp.web * | ||
| + | |||
| + | * PS is to contact VR via mattermost/IRC | ||
| + | |||
| + | * CB: WTP has its own guidelines for provisional API https://wiki.eclipse.org/WTP_API_Policy | ||
| + | |||
| + | * GE: let's say that most of it is provisional. | ||
| + | |||
| + | * GE, VR, plus we're going to remove several packages. we'll do in maintenance release. | ||
| + | |||
| + | * PS: We should stick to API, so the user can easily setup JSDT dev env. | ||
| + | |||
| + | * VR: This also create problem in mvn builds, and | ||
| + | |||
| + | === Newsletter === | ||
| + | Ilya: About Newsletter, we've added a couple of articles. If we want to help , '''''we should ping Ilya''''' and talkk about M7 contents. | ||
| + | |||
| + | NOTE: Deadline is the 12th of May | ||
Latest revision as of 11:57, 19 April 2016
Contents
JSDT/Confcalls/Minutes 20160412
Attendees : Victor R., Patrik, Ilya, Ian, Chuck, Victor S, Gorkem, Orlando, Alina
JSDT Quick references: JSDT pending changes (excl.SSE), JSDT Open Bugs
Debugger
Ilya: now debugger works in VFS, it is not clear yet how to add debug target.
Launch configuration: Adalberto and Ilya working together on this, meanwhile they fixed an Issue launching Nodejs config
The new image for the Node Launch: is in RH "design pipeline", better to ask to speed up the IP CQ process, to be completed before M7
Nodejs Runtime
- Orlando: has a Gerrit review pending
JSON Editor
Alina has the fix ready: it will be possible inserting between nodes, and it will also a speed up avoiding the reload of the entire model when removing a node.
Please see details in bug comments, and keep in mind this is not a sync problem, but this is related to insertion of nodes and the outline is not aligned with the model.
Chuck: however, there is a workaround, consisting in refresh the outline. And this proofs the model is correct.
Victor: we should wait for the fix, and open an issue related to outline. there is one kind of element (array) that gives problems when displayed into the outline. Probably is related to a model event not properly triggered
A new RH teammate will look into JSON editor. She will assign to herself the bugs she want to work on.
Victor R. added icons for outline tree
ES6
Gorkem: get the JSDT parser (Esprima) to work . There is a Gerrit review pending. It'll stay open for some time, for review, and It'll be merged.
For nested binary operations like ( 1 + ( 1 + 1 ) ) Esprima will have some limits we should look into
The keyworkd completion engine is in place, but you can't see it right now. You should wait for Ian work is committed to see the results from the correct code completion engine
Ian is working TDD-style and completing some last test before the code completion engine work as expected.
Shane: finished the work with template literals highlighting on JSDT editor (also nested) and Chromium debug editor (more simple). This is on master now. He is now working on exports in the outline view
Gorkem is to check ES6, and eventually add path entries using typescript or turn.js files.
Victor is looking at Gorkem changes and validation
Other Issues
Gorkem opened up a discussion about using SWTBot, nobody seems to have picked it up. probably we need to submit a request to WTP project
Victor R. we could also set up an instance for JSDT only, We should enable this on the HIPP (Hudson Instance Per Process) used by Gerrit.
It might be that the JSDT HIPP instance is the same HIPP that is used by WTP
Rob Stryker announced a change in Gerrit, as we used a kind of old version.
As you Type Validation fix depends on SSE. So this Fix works only for certain versions.
In some EPP packages the Nashorn classpath hooks stop working. there is some equinox work ongoing on this. Gorkem is to send some bug to EPP.
here is a link to an example bug sent to EPP: https://bugs.eclipse.org/bugs/show_bug.cgi?id=488781
There is a Wiki page about Equinox Hook for Nashorn : https://wiki.eclipse.org/JSDT/Equinox_hook_for_Nashorn
Ilya: About JS and EPP packages. we'll have no Gulp and Grunt notes in M6.
Which main features are we going to push : JSDT (SDK) + Nodejs Bower, NPM, Gulp Grunt + Nodejs runtime (is part of core), and it depends on Chromium debug core
- VR: It is bad to be on core, because we did not want to depend on Chromium
- > can we depend optionally on Chromium
- IB: Actually we're doing two launches (..)
- VR: if the user has his verison of Nodejs, what will happen ?
- GE: probably CNFE
- IB: How are we supposed to handle this ? IMO not possible to make it optional
- VR: so, IB: it's like an API call VR: so CNFE is user has multiple instances.
- GE: there are other EPP which actually are including JSDT, i.e. BIRT
- BIRT probably doesn't care about Nodejs
- CB: it is not completely breaking things, but some features are not working.
- VR: suggest to make this dependency optional, as we might want to use our verison of Chrome
- IB: it could be done, but It'll require some duplication of code from ChDevTools, to Nodejs
- VR: in the end it just instantiate some classes and call some methods, isn'it ?
- IB: Our Chromium can depend on JSDT, but other Nodejs instances are not depending on Chromium!
- GE: For the users including Chromium in JSDT is the most beneficial. They don't actually see the implementation of the debugger, they'll just like better how it work. (..) It'll be beneficial for users.
- VR: our first intention was to not to make it required.
- GE, CB: other option is to make that an optional feature, and have the EPP package include that feature
- IB: Only launch parameter from Ch are used in NodeLaunchConf. So we can remove the dependency and Just copy the Configuration.
- VR: it could be a problem in future, when changing the params, (GE ) despite we're doing it actually most of the times, in many Eclipse projects.
- VR: CB should include Chromium in JEE (CB)Ok
- CB: Is going to take care of the EPP Packages, and
API
Patrik: fixed some @since, and found some issues with project. dependencies, versions
- VR: indeed Rob Stryker reported some issue related to wtp.web *
- PS is to contact VR via mattermost/IRC
- CB: WTP has its own guidelines for provisional API https://wiki.eclipse.org/WTP_API_Policy
- GE: let's say that most of it is provisional.
- GE, VR, plus we're going to remove several packages. we'll do in maintenance release.
- PS: We should stick to API, so the user can easily setup JSDT dev env.
- VR: This also create problem in mvn builds, and
Newsletter
Ilya: About Newsletter, we've added a couple of articles. If we want to help , we should ping Ilya and talkk about M7 contents.
NOTE: Deadline is the 12th of May