Skip to main content
Jump to: navigation, search

Difference between revisions of "JDT Core/Plan/4.8/JEP325"

(Quick fixes)
(UI Changes)
 
(22 intermediate revisions by 2 users not shown)
Line 1: Line 1:
 
= Planning page for JDT Implementation of Switch Expressions (JEP 325) for Java 12 =
 
= Planning page for JDT Implementation of Switch Expressions (JEP 325) for Java 12 =
 +
<br />
 +
[https://bugs.eclipse.org/bugs/showdependencytree.cgi?id=536055&hide_resolved=1 | Bug 536055]
  
 
Main tracking bug: {{bug|542557}}
 
Main tracking bug: {{bug|542557}}
Line 10: Line 12:
 
This would be a major grammar change  effort/time estimate for grammar -
 
This would be a major grammar change  effort/time estimate for grammar -
 
Currently here - need to rewrite the grammar - est : done
 
Currently here - need to rewrite the grammar - est : done
 +
Additional minor but required grammar change was done to include parenthesis.
  
 
=== Compiler AST Creation ===
 
=== Compiler AST Creation ===
Line 18: Line 21:
  
 
=== Flow analysis changes ===
 
=== Flow analysis changes ===
will have flow analysis  changes  - in review - 3 days [https://bugs.eclipse.org/bugs/show_bug.cgi?id=542707 bug 542707]
+
will have flow analysis  changes  - [https://bugs.eclipse.org/bugs/show_bug.cgi?id=542707 bug 542707] - done
  
 
=== Error reports ===
 
=== Error reports ===
* new error reports. (2 days - in parallel with flow analysis ?) - in progress in parallel
+
* new error reports. (0 days - in parallel with flow analysis) - done
  
 
=== Code generation ===
 
=== Code generation ===
Addressing the breaks without label but with expressions and implicit break labels for switch label expressions - 1 week [https://bugs.eclipse.org/bugs/show_bug.cgi?id=542838 bug 542838]
+
Addressing the breaks without label but with expressions and implicit break labels for switch label expressions -0d [https://bugs.eclipse.org/bugs/show_bug.cgi?id=542838 bug 542838] - done
 +
Further issues found [https://bugs.eclipse.org/bugs/show_bug.cgi?id=544458 bug 544458] - done - 0d
  
 
== Java Search support ==
 
== Java Search support ==
slight change expected - 2d {{bug|542559}}
+
slight change expected - 0d {{bug|542559}} - done
 +
Additional issue found in {{bug|544304}} - done
  
 
== DOM support ==
 
== DOM support ==
ast changes expected - 1wk -- 1st patch review done, rework in progress
+
ast changes expected DOM AST change -0d - done
{{bug|542558}}
+
{{bug|542558}}<br>
 +
ast rewrite - 0d - done
 +
{{bug|543720}}<br>
 +
 
 +
== Formatter support ==
 +
ast changes expected - done
 +
{{bug|543818}}<br>
  
 
== Content Assist support ==
 
== Content Assist support ==
* additional place the content assist be applicable - 5 days ({{bug|542560}}
+
* additional place the content assist be applicable - 2 days ({{bug|542560}} - in progress
  
 
== Code Select support ==
 
== Code Select support ==
* additional place the content assist be applicable - 5 days ({{bug|542561}}
+
* additional place the content assist be applicable - ({{bug|542561}} - done - 0d
  
 
== UI Changes ==
 
== UI Changes ==
  
* Switch ASTs to JLS11 (generic - 1d)
+
* Switch ASTs to JLS12 (generic - 1d)
  
 
=== Code hover ===
 
=== Code hover ===

Latest revision as of 23:15, 17 March 2019

Planning page for JDT Implementation of Switch Expressions (JEP 325) for Java 12


| Bug 536055

Main tracking bug: bug 542557

Compiler changes

Changes regarding the compiler: bug 542557

Grammar changes

Switch Expression grammar changes - add bug number This would be a major grammar change effort/time estimate for grammar - Currently here - need to rewrite the grammar - est : done Additional minor but required grammar change was done to include parenthesis.

Compiler AST Creation

Tied with parsing - done

Type Inference

Type inference since switch expression may be an expression - bug 542871 - Done

Flow analysis changes

will have flow analysis changes - bug 542707 - done

Error reports

  • new error reports. (0 days - in parallel with flow analysis) - done

Code generation

Addressing the breaks without label but with expressions and implicit break labels for switch label expressions -0d bug 542838 - done Further issues found bug 544458 - done - 0d

Java Search support

slight change expected - 0d bug 542559 - done Additional issue found in bug 544304 - done

DOM support

ast changes expected DOM AST change -0d - done bug 542558
ast rewrite - 0d - done bug 543720

Formatter support

ast changes expected - done bug 543818

Content Assist support

  • additional place the content assist be applicable - 2 days (bug 542560 - in progress

Code Select support

  • additional place the content assist be applicable - (bug 542561 - done - 0d

UI Changes

  • Switch ASTs to JLS12 (generic - 1d)

Code hover

  • Show inferred type of variable - no change expected

Preferences

  • Allow JDT UI to target Java 11 in Compiler Preferences - generic (1d in parallel)

Quick fixes

  • convert to a switch statement ( 3 DAYS? jdt.ui to comment)
  • coalesce two or more case statements to comma separated case label statements - 4 ays> jdt.ui ? opportunistic
  • see bug 543665

Code templates

  • add switch in templates - 1d

JDT Debug

  • Expected to have an impact - especially breakpoints - 1w approx

Back to the top