Skip to main content

Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

Difference between revisions of "Hudson-ci/eclipse migration/Hudson Code Contributions"

 
(33 intermediate revisions by 2 users not shown)
Line 5: Line 5:
 
= Status of Initial Code Contributions  =
 
= Status of Initial Code Contributions  =
  
For the purpose of the initial code contribution, Hudson is split into 10 modules which will correspond to the GIT repositories in use:  
+
For the purpose of the initial code contribution, Hudson is split into over 10 modules which will map back to the GIT repositories in use. Note that some repositories will amalgamate multiple contribution zip files:  
  
Submission State
+
== Core Code Contributions  ==
  
<br>
+
{| width="100%" cellspacing="1" cellpadding="1" border="1"
 
+
{| width="100%" border="1" cellpadding="1" cellspacing="1"
+
 
|-
 
|-
 
| '''Module'''  
 
| '''Module'''  
Line 17: Line 15:
 
| '''Bugzilla'''  
 
| '''Bugzilla'''  
 
| '''Status'''  
 
| '''Status'''  
 +
| '''Status At'''
 
| '''Notes'''
 
| '''Notes'''
 
|-
 
|-
Line 22: Line 21:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5461 5461]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5461 5461]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354029 354029]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354029 354029]  
| Resubmitted
+
| Approved
| Initially the following files were identified as possibly nested JAR or ZIP files:<br>./src/Hudson-core/hudson-core/src/test/resources/hudson/remoteCopyFiles.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/maven-2.0.7-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-2.2.1-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-3.0.1-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-ant-1.8.1-bin.zip<br>Guidance from Winston was to delete the ANT and MAven files as they can actually be obtained at runtime and do not need to be checked in
+
| 19th/Sep
 +
|
 +
Initially the following files were identified as possibly nested JAR or ZIP files:<br>./src/Hudson-core/hudson-core/src/test/resources/hudson/remoteCopyFiles.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/maven-2.0.7-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-2.2.1-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-3.0.1-bin.zip<br>./src/Hudson-core/hudson-test-framework/src/main/resources/apache-ant-1.8.1-bin.zip<br>Guidance from Winston was to delete the ANT and Maven files as they can actually be obtained at runtime and do not need to be checked in  
 +
 
 +
The remoteCopyFiles has been expanded in place.
 +
 
 +
There are still some issues with MIT licences and some CSS - passed to Winston
 +
 
 +
----
 +
 
 +
11-Aug: Split out Hudson-war into separate code package
 +
 
 +
2-Sept: additional clean up of comments etc.
 +
 
 
|-
 
|-
 
| SVN  
 
| SVN  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5469 5469]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5469 5469]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354031 354031]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354031 354031]  
| No CQ upload yet
+
| Approved
 +
| 11/Aug
 
|  
 
|  
Zip files in contribution:  
+
Initially Zip files in contribution:  
  
 
Several zip files in src\test\resources\org\eclipse\hudson\scm\subversion\*  
 
Several zip files in src\test\resources\org\eclipse\hudson\scm\subversion\*  
  
Can these be expanded oe deleted?
+
Deleted these - don't need them. Updated bugzilla and submitted amended version to ipzilla
  
 
|-
 
|-
Line 40: Line 53:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5464 5464]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5464 5464]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354037 354037]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354037 354037]  
| Awaiting IP Review  
+
| Approved for Parallel IP Review  
 +
| 11/Aug
 
| Code submitted in Bugzilla and CQ
 
| Code submitted in Bugzilla and CQ
 
|-
 
|-
Line 46: Line 60:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5471 5471]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5471 5471]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354034 354034]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354034 354034]  
| No CQ upload yet
+
| Approved for Parallel IP Review
 +
| 11/Aug
 
|  
 
|  
 
Zip files in contribution:  
 
Zip files in contribution:  
Line 53: Line 68:
  
 
Can these be deleted or expanded in the context of the code contribution  
 
Can these be deleted or expanded in the context of the code contribution  
 +
 +
Decision - files removed and clean versions uploaded.
 +
 +
Aug-11: Logged issue to investigate the "secret.key" file included in the contribution
  
 
|-
 
|-
Line 58: Line 77:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5465 5465]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5465 5465]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354039 354039]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354039 354039]  
| Awaiting IP Review
+
| Approved
| Code submitted in Bugzilla and CQ
+
| 19/Sep
 +
|
 +
08-Aug: Code submitted in Bugzilla and CQ  
 +
 
 +
08-Aug: Response from Wayne
 +
 
 +
''svnkit-1.3.2 is buried inside the BlameSubversion-1.121.hpi file (which is<br>itself an embedded library--we'll need the sources for that). These third-party<br>libraries will have to be contributed separately.''
 +
 
 +
''I also noticed that the corresponding POM file is MIT-licensed. Is that<br>intended?''
 +
 
 +
----
 +
 
 +
11-Aug: Hudson Bugzilla issues raised to address these
 +
 
 +
----
 +
 
 +
12-Aug: issues addressed and new version of archive uploaded to Bugzilla and CQ.
 +
 
 
|-
 
|-
 
| CVS  
 
| CVS  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5468 5468]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5468 5468]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354033 354033]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354033 354033]  
| Awaiting IP Review
+
| Approved
 +
| 11/Aug
 
| Code submitted in Bugzilla and CQ
 
| Code submitted in Bugzilla and CQ
 
|-
 
|-
Line 70: Line 107:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5466 5466]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5466 5466]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354032 354032]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354032 354032]  
| Awaiting IP Review  
+
| Awaiting IP Review&nbsp;
| Code submitted in Bugzill and CQ
+
| 11/Aug
 +
|
 +
08-Aug: Code submitted in Bugzilla and CQ  
 +
 
 +
----
 +
 
 +
11-Aug: Comment from Wayne:<br>''There is third-party code in this contribution from Maven. Why is this code<br>copied rather than just compiled against the Maven libraries directly?<br>If you do need to copy the Maven code, that code should be contributed via a separate CQ.''
 +
 
 +
<br>
 +
 
 +
11-Aug [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5466#c6 Response]&nbsp;
 +
 
 +
----
 +
 
 
|-
 
|-
 
| UI Tests  
 
| UI Tests  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5462 5462]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5462 5462]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354035 354035]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354035 354035]  
| Awaiting IP Review
+
| Approved
 +
| 19/Sep
 
|  
 
|  
Code submitted in Bugzilla and CQ - Possible issue:  
+
08-Aug: Code submitted in Bugzilla and CQ - <br>Possible issue:  
  
The git-2.0.0.hpi file is an embedded archive that needs to be separately<br>contributed (I assume that it's a third-party library). That file contains<br>several other libraries (including jGit); the third-party stuff will require<br>separate CQs (JGit should not require a CQ as it is an Eclipse project).  
+
''The git-2.0.0.hpi file is an embedded archive that needs to be separately<br>contributed (I assume that it's a third-party library). That file contains<br>several other libraries (including jGit); the third-party stuff will require<br>separate CQs (JGit should not require a CQ as it is an Eclipse project).''
 +
 
 +
----
 +
 
 +
11-Aug: Logged Hudson issue to extract HPI
 +
 
 +
<br>
 +
 
 +
2-Sep: Uploaded new version without the HPI to CQ and Bugzilla
 +
 
 +
----
  
 
|-
 
|-
Line 86: Line 147:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5470 5470]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5470 5470]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354036 354036]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354036 354036]  
| Awaiting IP Review
+
| Approved
 +
| 11/Aug
 
| Code submitted in Bugzilla and CQ
 
| Code submitted in Bugzilla and CQ
 
|-
 
|-
Line 92: Line 154:
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5463 5463]  
 
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5463 5463]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354038 354038]  
 
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354038 354038]  
| Awaiting IP Review
+
| Approved
| Code submitted in Bugzilla and CQ
+
| 11/Aug
 +
| Code submitted in Bugzilla and CQ  
 +
| <br>
 +
|-
 +
| Core WAR
 +
| [https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5515 5515]
 +
| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=354526 354526]
 +
| Approved
 +
| 06/Sep
 +
| 11-Aug: Initial Bugzilla load - but still needs extra checks so not yet associated with the CQ
 +
----
 +
 
 +
12-Aug: about.html added to contribution. Bugzilla record updated by Winston. Upload into CQ by Duncan
 +
 
 +
----
 +
 
 +
06-Sept-2011 - Query about the source of images from Wayne:
 +
 
 +
''These libraries each need to be entered as separate CQs, unless you have been explicitly instructed otherwise by Janet.'' What is the source of the images?
 +
 
 
|}
 
|}
 +
 +
== 3rd Party Libraries Used By Hudson At The Time of the Contribution&nbsp; ==
 +
 +
For third party library dependencies present at the time of contribution [[Hudson-ci/development/third party libraries|refer to this page]].
 +
 +
<br>

Latest revision as of 07:54, 31 January 2012

Hudson-headonly.png

Back to Hudson-ci home

Status of Initial Code Contributions

For the purpose of the initial code contribution, Hudson is split into over 10 modules which will map back to the GIT repositories in use. Note that some repositories will amalgamate multiple contribution zip files:

Core Code Contributions

Module CQ in IPzilla Bugzilla Status Status At Notes
Core 5461 354029 Approved 19th/Sep

Initially the following files were identified as possibly nested JAR or ZIP files:
./src/Hudson-core/hudson-core/src/test/resources/hudson/remoteCopyFiles.zip
./src/Hudson-core/hudson-test-framework/src/main/resources/maven-2.0.7-bin.zip
./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-2.2.1-bin.zip
./src/Hudson-core/hudson-test-framework/src/main/resources/apache-maven-3.0.1-bin.zip
./src/Hudson-core/hudson-test-framework/src/main/resources/apache-ant-1.8.1-bin.zip
Guidance from Winston was to delete the ANT and Maven files as they can actually be obtained at runtime and do not need to be checked in

The remoteCopyFiles has been expanded in place.

There are still some issues with MIT licences and some CSS - passed to Winston


11-Aug: Split out Hudson-war into separate code package

2-Sept: additional clean up of comments etc.

SVN 5469 354031 Approved 11/Aug

Initially Zip files in contribution:

Several zip files in src\test\resources\org\eclipse\hudson\scm\subversion\*

Deleted these - don't need them. Updated bugzilla and submitted amended version to ipzilla

Packaging 5464 354037 Approved for Parallel IP Review 11/Aug Code submitted in Bugzilla and CQ
Test Harness 5471 354034 Approved for Parallel IP Review 11/Aug

Zip files in contribution:

Many ZIP files under Hudson-test-harness\src\test\resources\hudson\*

Can these be deleted or expanded in the context of the code contribution

Decision - files removed and clean versions uploaded.

Aug-11: Logged issue to investigate the "secret.key" file included in the contribution

Update Center 5465 354039 Approved 19/Sep

08-Aug: Code submitted in Bugzilla and CQ

08-Aug: Response from Wayne

svnkit-1.3.2 is buried inside the BlameSubversion-1.121.hpi file (which is
itself an embedded library--we'll need the sources for that). These third-party
libraries will have to be contributed separately.

I also noticed that the corresponding POM file is MIT-licensed. Is that
intended?


11-Aug: Hudson Bugzilla issues raised to address these


12-Aug: issues addressed and new version of archive uploaded to Bugzilla and CQ.

CVS 5468 354033 Approved 11/Aug Code submitted in Bugzilla and CQ
Maven 5466 354032 Awaiting IP Review  11/Aug

08-Aug: Code submitted in Bugzilla and CQ


11-Aug: Comment from Wayne:
There is third-party code in this contribution from Maven. Why is this code
copied rather than just compiled against the Maven libraries directly?
If you do need to copy the Maven code, that code should be contributed via a separate CQ.


11-Aug Response 


UI Tests 5462 354035 Approved 19/Sep

08-Aug: Code submitted in Bugzilla and CQ -
Possible issue:

The git-2.0.0.hpi file is an embedded archive that needs to be separately
contributed (I assume that it's a third-party library). That file contains
several other libraries (including jGit); the third-party stuff will require
separate CQs (JGit should not require a CQ as it is an Eclipse project).


11-Aug: Logged Hudson issue to extract HPI


2-Sep: Uploaded new version without the HPI to CQ and Bugzilla


GIT 5470 354036 Approved 11/Aug Code submitted in Bugzilla and CQ
Slaves 5463 354038 Approved 11/Aug Code submitted in Bugzilla and CQ
Core WAR 5515 354526 Approved 06/Sep 11-Aug: Initial Bugzilla load - but still needs extra checks so not yet associated with the CQ

12-Aug: about.html added to contribution. Bugzilla record updated by Winston. Upload into CQ by Duncan


06-Sept-2011 - Query about the source of images from Wayne:

These libraries each need to be entered as separate CQs, unless you have been explicitly instructed otherwise by Janet. What is the source of the images?

3rd Party Libraries Used By Hudson At The Time of the Contribution 

For third party library dependencies present at the time of contribution refer to this page.


Back to the top