Notice: This Wiki is now read only and edits are no longer possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "Sapphire/FlexibleDiagramNodeShapes"
Line 1: | Line 1: | ||
− | This page tracks ongoing issues and discussions pertaining to [https://bugs.eclipse.org/bugs/show_bug.cgi?id=383924 Bug 383924]. | + | This page tracks ongoing issues and discussions pertaining to [https://bugs.eclipse.org/bugs/show_bug.cgi?id=383924 Bug 383924]. |
− | '''Issues raised from the UI review with our usability expert:''' | + | '''Issues raised from the UI review with our usability expert:''' |
− | 1. | + | 1. Combo cell editor should be used when direct editing an enum property [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404500 Bug 404500] resolved |
− | 2. Remove "direct edit" context menu [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404503 Bug 404503] resolved | + | 2. Remove "direct edit" context menu [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404503 Bug 404503] resolved |
− | 3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404499 Bug 404499] resolved | + | 3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404499 Bug 404499] resolved |
− | 4. | + | 4. [Sql Schema Editor Sample] Add column action in table node's floating palette doesn't work [https://bugs.eclipse.org/bugs/show_bug.cgi?id=404501 Bug 404501] resolved |
'''Miscellaneous issues:''' | '''Miscellaneous issues:''' | ||
− | 1. Direct editing a newly created node doesn't hide the node label. | + | 1. <strike>Direct editing a newly created node doesn't hide the node label.</strike> |
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d4ccb7d0064a970c96dbdf3dc23676e2155bdf79 | ||
+ | |||
+ | <strike>2. Select a node that can be resized (ex. sqlschema.xml) and make the node larger.</strike> | ||
− | |||
a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not | a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not | ||
− | + | b. Continue to add columns, node does not expand to fit all the newly added columns | |
− | + | c. Edit the column type which is a combo and it extends outside the node, not utilize the available space. | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d96f45b960d95b7ccf712b589612ce5c39bc8f43 | + | |
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d96f45b960d95b7ccf712b589612ce5c39bc8f43 | ||
+ | |||
+ | 3.<strike>Reorder column (ex. sqlschema.xml) and column inserted in different location than the visual aid (one column below). Works if moving to a column above. Also the visual aid feedback is a few pixel too big. </strike> | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bcf33857fb440acb7895a17f3d5f74b6e1957c1f | ||
+ | |||
+ | 4. <strike>Drag/drop does not work when moving to the last item - same bug as 3, didn't completely fix. </strike> | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=7459594a669c7dd7790d61c891cd30fe042d5662 | ||
+ | |||
+ | 5.<strike>Drag/drop feedback should match orange guide lines</strike>. | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5ed5db1ff475879c2f8a9e8db4f1e5c9cd1b0a49 | ||
+ | |||
+ | 6. <strike>UML test case - line figure extends to the right edge, ignored specified margin. </strike> | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=bb35b4d334ada840adf960f3c06fd4fecfefaca7 | ||
+ | |||
+ | 7.<strike>Shape Factory always places its children in the 0th index position</strike>. | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=85a274836593b352e977e066e5e38f76ec3d1530 | ||
+ | |||
+ | 8. <strike>"Show in source" context button not placed correctly in UML text case.</strike> | ||
+ | |||
+ | <strike></strike>Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=68fe36f36c89455dc59431ae2caec035bdab4037 | ||
+ | |||
+ | 9. <strike>Shape factory with no separator NPE. </strike> | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=e18f4d6e5e8e8897247707f037a19133efa27c35 | ||
+ | |||
+ | 10. <strike>Shape factory -> Case -> Text, note editing not allowed, manual editing in source code results in NPE </strike> | ||
+ | |||
+ | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=ea1d0a618962d0f152288624b513f7dea56db9f0 | ||
+ | |||
+ | 11.<strike>Shape factory -> Case -> Rectangle -> Rectangle -> Validation Marker not displayed.</strike> | ||
+ | |||
+ | Workaround: Shape factory -> Case -> Rectangle -> Validation Marker | ||
− | + | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=c542a7f75e653d2eb9edc97b7d982c4c82f2e071 | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id= | + | |
− | + | 12. <strike>sqlschema.xml -> edit the <type>, and type in an invalid text "aaa". Notice the text is still <type>. Type in another invalid text "bbb". Now view the error message, "aaa" is not a valid column type, and notice the error message did not update. </strike> | |
− | + | ||
− | + | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=dc56d000a915a5295b8959dc8047f6aff9a7c342 | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id= | + | |
− | + | 12.b <strike>atchitecture.xml -> The error message is not shown in the assist dialog. </strike> | |
− | + | ||
− | + | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=3bf509dbe1ee6b77d91878e9b410ab26cbad2dc9 | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id= | + | |
− | + | 13. <strike>uml.xml -> extra spacing at the end (when the top text margin is 5) </strike> | |
− | + | ||
− | + | Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=879fbe5c5d4588472387ba089306b0423d34f120 | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id= | + | |
− | + | 14. uml.mxl -> visible-when on a Rectangle that contains ShapeFactory. First add -> child not added Subsequent add -> ERROR : Figure is not a child java.lang.IllegalArgumentException: Figure is not a child | |
− | + | ||
− | + | <br> <strike>15. sqlschema.xml -> add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.</strike> | |
− | + | ||
− | + | ||
− | + | This is not an issue. The sql schema editor's column layout has the column name field left aligned but doesn't expand. The column type field is right aligned and does expand to take up the extra space. So even if the name column appears to have extra space, it is the column type field that has the extra space.<br> | |
− | + | ||
− | + | 16. <strike>Need a test case for nested shape factories. </strike> | |
− | + | ||
− | + | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=27b96267109590f0285799f149b609fcd1435077 | |
− | Resolved | + | |
− | + | 17. sqlschema.xml -> add a new column to a table in source editor, the new column is always displayed as the last column in the diagram editor even if the new column is inserted in the middle of the table in the source editor. | |
− | + | ||
− | + | ||
− | + | ||
− | + | 18. <strike>Shape factory -> Case -> Text, the text is editable, selectable and movable, but the selection border is not displayed. </strike> | |
− | + | Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=d6cae2475ac1a9608e6738e70a8102736c30d64a | |
− | Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id= | + | |
− | + | 19. Added 3 nested Rectangle - each with a different color border and only one of the border is shown. | |
− | + | 20. <strike>In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case. </strike> | |
− | + | ||
− | + | <strike></strike>Resolved http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=27b96267109590f0285799f149b609fcd1435077 | |
− | + | 21. <strike>Alignment for shapes is only applied when "expand" bit is turned on, making text with default alignment which is center-aligned appear to be left-aligned when there is extra space for the text shape. It's also inconsistent with the cell editor locator for the text figure when direct-editing. </strike> | |
− | + | ||
− | |||
Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5f3fd8c25e08d3d948f01e2180a45af18f6b2b2f | Resolved: http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=5f3fd8c25e08d3d948f01e2180a45af18f6b2b2f |
Revision as of 18:10, 11 July 2013
This page tracks ongoing issues and discussions pertaining to Bug 383924.
Issues raised from the UI review with our usability expert:
1. Combo cell editor should be used when direct editing an enum property Bug 404500 resolved
2. Remove "direct edit" context menu Bug 404503 resolved
3. [Sql Schema Editor Sample] SqlSchema editor sample should include toggle primary key context menu Bug 404499 resolved
4. [Sql Schema Editor Sample] Add column action in table node's floating palette doesn't work Bug 404501 resolved
Miscellaneous issues:
1. Direct editing a newly created node doesn't hide the node label.
2. Select a node that can be resized (ex. sqlschema.xml) and make the node larger.
a. Edit the table label so it is larger, it should have expanded the node to make it fit but does not b. Continue to add columns, node does not expand to fit all the newly added columns c. Edit the column type which is a combo and it extends outside the node, not utilize the available space.
3.Reorder column (ex. sqlschema.xml) and column inserted in different location than the visual aid (one column below). Works if moving to a column above. Also the visual aid feedback is a few pixel too big.
4. Drag/drop does not work when moving to the last item - same bug as 3, didn't completely fix.
5.Drag/drop feedback should match orange guide lines.
6. UML test case - line figure extends to the right edge, ignored specified margin.
7.Shape Factory always places its children in the 0th index position.
8. "Show in source" context button not placed correctly in UML text case.
9. Shape factory with no separator NPE.
10. Shape factory -> Case -> Text, note editing not allowed, manual editing in source code results in NPE
11.Shape factory -> Case -> Rectangle -> Rectangle -> Validation Marker not displayed.
Workaround: Shape factory -> Case -> Rectangle -> Validation Marker
12. sqlschema.xml -> edit the <type>, and type in an invalid text "aaa". Notice the text is still <type>. Type in another invalid text "bbb". Now view the error message, "aaa" is not a valid column type, and notice the error message did not update.
12.b atchitecture.xml -> The error message is not shown in the assist dialog.
13. uml.xml -> extra spacing at the end (when the top text margin is 5)
14. uml.mxl -> visible-when on a Rectangle that contains ShapeFactory. First add -> child not added Subsequent add -> ERROR : Figure is not a child java.lang.IllegalArgumentException: Figure is not a child
15. sqlschema.xml -> add a table with 2 columns. Give the first column a longer name, edit the second column name. Notice it does not expand to the maximum allowed width.
This is not an issue. The sql schema editor's column layout has the column name field left aligned but doesn't expand. The column type field is right aligned and does expand to take up the extra space. So even if the name column appears to have extra space, it is the column type field that has the extra space.
16. Need a test case for nested shape factories.
17. sqlschema.xml -> add a new column to a table in source editor, the new column is always displayed as the last column in the diagram editor even if the new column is inserted in the middle of the table in the source editor.
18. Shape factory -> Case -> Text, the text is editable, selectable and movable, but the selection border is not displayed.
19. Added 3 nested Rectangle - each with a different color border and only one of the border is shown.
20. In sdef editor, min size, max size, size, expand fields don't show up in the "layout constraint" details page for shapes contained by shape factory case.
21. Alignment for shapes is only applied when "expand" bit is turned on, making text with default alignment which is center-aligned appear to be left-aligned when there is extra space for the text shape. It's also inconsistent with the cell editor locator for the text figure when direct-editing.