Notice: This Wiki is now read only and edits are no longer possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "Hudson-ci/Planning/Library Cleanup"
| Line 21: | Line 21: | ||
By package / source file: | By package / source file: | ||
| − | Strikethrough indicates no significant diffs apart from comments / copyright. Bold used to indicate code change within a statement. | + | Strikethrough indicates no significant diffs apart from comments / copyright. Bold used to indicate simple code change within a statement. |
<br> | <br> | ||
| Line 27: | Line 27: | ||
{| width="100%" border="1" cellpadding="1" cellspacing="1" summary="Codebase Diffs" | {| width="100%" border="1" cellpadding="1" cellspacing="1" summary="Codebase Diffs" | ||
|- | |- | ||
| − | | Package | + | | '''Package''' |
| − | | Class | + | | '''Class''' |
| − | | Diff | + | | '''Diff''' |
| − | | Function | + | | '''Function''' |
| − | | Origional (1.1 JAF) | + | | '''Origional (1.1 JAF)''' |
| − | | Hudson | + | | '''Hudson''' |
|- | |- | ||
| com.sun.<br>activation.registries | | com.sun.<br>activation.registries | ||
| Line 79: | Line 79: | ||
| MailcapTokenizer.java | | MailcapTokenizer.java | ||
| 1 | | 1 | ||
| − | | public void setAutoquoteChar(char value) | + | | public void setAutoquoteChar(char value) |
| − | | <br> | + | | <br> |
| − | | Function Not Present | + | | '''Function Not Present''' |
|- | |- | ||
| | | | ||
| | | | ||
| − | | | + | | 2 |
| − | | | + | | public int nextToken() |
| − | | | + | | if (isAutoquoting) {<br> if (!isAutoquoteSpecialChar(c)) {<br> processAutoquoteToken();<br> } else if ((c == ';') || (c == '=')) {<br> currentToken = c;<br> currentTokenValue = new Character(c).toString();<br> ++dataIndex;<br> } else {<br> currentToken = UNKNOWN_TOKEN;<br> currentTokenValue = new Character(c).toString();<br> ++dataIndex;<br> } |
| − | | | + | | if (isAutoquoting) {<br> if (c == ';' || c == '=') {<br> currentToken = c;<br> currentTokenValue = new Character(c).toString();<br> ++dataIndex;<br> } else {<br> processAutoquoteToken();<br> } |
|- | |- | ||
| | | | ||
| | | | ||
| + | | 3 | ||
| + | | public static boolean isAutoquoteSpecialChar(char c) | ||
| | | | ||
| − | | | + | | '''Function Not Present''' |
| − | + | ||
| − | + | ||
|- | |- | ||
| | | | ||
| − | | | + | | <strike>MimeTypeEntry.java</strike> |
| | | | ||
| | | | ||
| Line 105: | Line 105: | ||
|- | |- | ||
| | | | ||
| − | | | + | | <strike>MimeTypeFile.java</strike> |
| | | | ||
| | | | ||
| Line 112: | Line 112: | ||
|- | |- | ||
| | | | ||
| − | | | + | com.sun.<br>activation.viewers |
| + | |||
| + | | <strike>ImageViewer.java</strike> | ||
| | | | ||
| | | | ||
| Line 119: | Line 121: | ||
|- | |- | ||
| | | | ||
| − | | | + | | <strike>ImageViewerCanvas.java</strike> |
| | | | ||
| | | | ||
| Line 126: | Line 128: | ||
|- | |- | ||
| | | | ||
| − | | | + | | TextEditor.java |
| − | | | + | | 1 |
| − | | | + | | public void setInputStream(InputStream ins) |
| − | | | + | | // make sure we got one<br> if(fos == null) {<br> System.out.println("Invalid outputstream in TextEditor!");<br> System.out.println("not saving!");<br> } |
| − | | | + | | // make sure we got one<br> if(fos == null) {<br> System.out.println("Invalid outputstream in TextEditor!");<br> System.out.println("not saving!");<br> '''return;'''<br> } |
|- | |- | ||
| | | | ||
| − | | | + | | <strike>TextViewer.java</strike> |
| | | | ||
| | | | ||
Revision as of 05:19, 29 November 2011
| Hudson Continuous Integration Server | |
| Website | |
| Download | |
| Community | |
| Mailing List • Forums • IRC • mattermost | |
| Issues | |
| Open • Help Wanted • Bug Day | |
| Contribute | |
| Browse Source |
|
Library Cleanup Project |
|---|
Contents
Introduction
One of the major problems with the original Hudson code-base was the use of several of forked / patched 3rd party libraries. It's in no-one's interest to have to maintain separate code-bases in these cases and so we need to look at contributing any patches back to the original projects and removing the dependency on the patched versions This page tracks the libraries that we need to concentrate on as part of this process
JavaBeans Activation Framework
Hudson uses a patched version of activation.jar derived from git://github.com/kohsuke/javax.activation.git
The home of the base project is now the GlassFish Project: https://svn.java.net/svn/glassfish~svn/trunk/external/modules/activation
Tracking
This project is related to CQ: 5774
This project is tracked by BugZilla: 364988
Diffs
By package / source file:
Strikethrough indicates no significant diffs apart from comments / copyright. Bold used to indicate simple code change within a statement.
| Package | Class | Diff | Function | Origional (1.1 JAF) | Hudson |
| com.sun. activation.registries |
|
||||
| MailcapFile.java | 1 | public String[] getNativeCommands(String mime_type) | List v = (List)native_commands.get( mime_type.toLowerCase()); |
List v = (List)native_commands.get( mime_type.toLowerCase(Locale.ENGLISH)); | |
| 2 | protected void parseLine(String mailcapEntry) | String primaryType = tokenizer.getCurrentTokenValue().toLowerCase(); | String primaryType = tokenizer.getCurrentTokenValue().toLowerCase(Locale.ENGLISH); | ||
| 3 | subType = tokenizer.getCurrentTokenValue().toLowerCase(); | subType = tokenizer.getCurrentTokenValue().toLowerCase(Locale.ENGLISH); | |||
| String paramName = tokenizer.getCurrentTokenValue().toLowerCase(); |
String paramName = tokenizer.getCurrentTokenValue(). toLowerCase(Locale.ENGLISH); | ||||
| |
|||||
| MailcapTokenizer.java | 1 | public void setAutoquoteChar(char value) | |
Function Not Present | |
| 2 | public int nextToken() | if (isAutoquoting) { if (!isAutoquoteSpecialChar(c)) { processAutoquoteToken(); } else if ((c == ';') || (c == '=')) { currentToken = c; currentTokenValue = new Character(c).toString(); ++dataIndex; } else { currentToken = UNKNOWN_TOKEN; currentTokenValue = new Character(c).toString(); ++dataIndex; } |
if (isAutoquoting) { if (c == ';' || c == '=') { currentToken = c; currentTokenValue = new Character(c).toString(); ++dataIndex; } else { processAutoquoteToken(); } | ||
| 3 | public static boolean isAutoquoteSpecialChar(char c) | Function Not Present | |||
| |
|||||
| |
|||||
|
com.sun. |
|
||||
| |
|||||
| TextEditor.java | 1 | public void setInputStream(InputStream ins) | // make sure we got one if(fos == null) { System.out.println("Invalid outputstream in TextEditor!"); System.out.println("not saving!"); } |
// make sure we got one if(fos == null) { System.out.println("Invalid outputstream in TextEditor!"); System.out.println("not saving!"); return; } | |
| |
|||||
Xstream XML Parser
Husdon uses a patched version of xstream:
The home of the base project is on Codehaus: http://svn.codehaus.org/xstream/trunk/
Tracking
This project is related to CQ: 5771
This project is tracked by BugZilla:
Diffs
The issues tracking the diffs on Codehaus are: http://jira.codehaus.org/browse/XSTR-676 http://jira.codehaus.org/browse/XSTR-675 http://jira.codehaus.org/browse/XSTR-674