Notice: This Wiki is now read only and edits are no longer possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "Talk:EclipseLink/Development/JPA2.0/Extended Map support/MappedKeyMapContainerPolicy"
(New page: ==Some comments== * I updated some typos, added "Supported Features" sections and some open issues. * The doc should include the JPA annotations and XML defined for this mapping. * How wil...) |
(→Some comments) |
||
Line 8: | Line 8: | ||
* Is a new mapping the best design for this, what are the pros/cons over creating a MapPolicy in ForeignReferenceMapping? It seems like a lot of complex things that are done in AggregateCollectionMapping and UnidirectionalOneToManyMapping may require duplication. | * Is a new mapping the best design for this, what are the pros/cons over creating a MapPolicy in ForeignReferenceMapping? It seems like a lot of complex things that are done in AggregateCollectionMapping and UnidirectionalOneToManyMapping may require duplication. | ||
* Will this mapping use the old commit like AggregateCollectionMapping, or build its ChangeRecord correctly? | * Will this mapping use the old commit like AggregateCollectionMapping, or build its ChangeRecord correctly? | ||
+ | * If the keys are Entities (and possibly values) how will the data be read, a single query or n+1 queries? | ||
:[[User:James.sutherland.oracle.com|James.sutherland.oracle.com]] 16:23, 17 November 2008 (UTC) | :[[User:James.sutherland.oracle.com|James.sutherland.oracle.com]] 16:23, 17 November 2008 (UTC) |
Revision as of 16:44, 18 November 2008
Some comments
- I updated some typos, added "Supported Features" sections and some open issues.
- The doc should include the JPA annotations and XML defined for this mapping.
- How will the attribute accessors on the nested mappings be used, or what aspects of the nested mappings will be used?
- What is the public API for this new mapping? There should be an API sections that defines this.
- The name seems odd, perhaps just MapMapping, or use the JPA name, CollectionOfElementsMapping, or ElementMapMapping.
- Is a new ChangeRecord created for this mapping, how does it determine what changed?
- Is a new mapping the best design for this, what are the pros/cons over creating a MapPolicy in ForeignReferenceMapping? It seems like a lot of complex things that are done in AggregateCollectionMapping and UnidirectionalOneToManyMapping may require duplication.
- Will this mapping use the old commit like AggregateCollectionMapping, or build its ChangeRecord correctly?
- If the keys are Entities (and possibly values) how will the data be read, a single query or n+1 queries?
- James.sutherland.oracle.com 16:23, 17 November 2008 (UTC)