Talk:EclipseLinkNewAttributeMappings

Discussion

For the @BasicCollection and @BasicMap the value/key column's table should not show (Employee) as the default. The table is the basic table, and you cannot change it, so should just remove this table setting.

The private-owned is not an option on the mappings, should be removed.

The join-fetch default is not inner, it is no join-fetch. Should either be checkbox disabled (and not show an option unless checked), or show "Default (None)".

James.sutherland.oracle.com 14:02, 21 July 2008 (EDT)

Well, looking in the code, the default CollectionTable name is defined based on the table set on either the value/key column. If a CollectionTable is specified directly, then the keyColumn or valueColumn table setting is ignored. This just feels wrong to me, I like your suggestion to ignore the table element(and then the runtime should throw an exception if it is set, not use it for the CollectionTable default name).

Good call on private-owned, have updated the screen shots.

Updated the screen shots to handle JoinFetch with a check box

Karen.moore.oracle.com 21:00, 21 July 2008 (EDT)