Skip to main content

Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

Difference between revisions of "Talk:EclipseLink/DesignDocs/214519"

(ELTable)
(@ELTable?)
Line 4: Line 4:
 
----
 
----
  
== @ELTable? ==
+
== Naming & Annotations? ==
  
 
--[[User:Douglas.clarke.oracle.com|Doug]] 13:58, 5 October 2010 (UTC)
 
--[[User:Douglas.clarke.oracle.com|Doug]] 13:58, 5 October 2010 (UTC)
My first impression is that I am not fond of duplicating standard JPA annotations with EL prefix if it can be avoided.
+
 
* Is this really a table scoped feature or is it a PU level config that should be applied to all tables (Note: Have not read the original request).
+
A couple of comments:
* PU Config
+
# eclipselink.ddl.default-table-suffix: is it really a table suffix? That name implies to me additional text added to the table name. Its really a suffix added to CREATE TABLE command
** PU Property
+
# @ELTable annotation? I do not like duplicated @Table in @ELTable
** Even if it is a table level config it would be nice to configure it once for all tables using a PU property
+
#* Do we even need an annotation? Is PU property and eclipselink-orm.xml enough?
* eclipselink-orm.xml would allow an additional optional attribute in <table .../>
+
* Annotation
+
** If it is required at a per table level should we consider only supporting this using an eclipselink-orm.xml?
+
** If we believe an annotation is essential is there a better pattern to extend @Table without duplicating it?
+

Revision as of 10:06, 5 October 2010

Everything in @ELTable should be optional and the contents should override that of @Table.
What about a calling the annotation @TableExt (Ext for extension) or @TableOverrides or something else?
Gordon Yorke 13:58, 1 October 2010 (UTC)


Naming & Annotations?

--Doug 13:58, 5 October 2010 (UTC)

A couple of comments:

  1. eclipselink.ddl.default-table-suffix: is it really a table suffix? That name implies to me additional text added to the table name. Its really a suffix added to CREATE TABLE command
  2. @ELTable annotation? I do not like duplicated @Table in @ELTable
    • Do we even need an annotation? Is PU property and eclipselink-orm.xml enough?

Back to the top