Jump to: navigation, search


Revision as of 08:02, 6 January 2011 by Eclipse.mycontact.org (Talk | contribs) (Classes)

This page shall provide a discussion about the EMF Editor and about some improvements:

Please try to reflect the structure of the main page and please explain the current situation on the main page before starting a discussion about:



The code generator produces just 4 classes. This is nice in the first place because you get a fast overview on all classes but if you take a closer look into the editor class it covers to many aspects just in one class.

There is so many stuff included ....

Class definition

As you can see the editor extends directly the MultiPageEditorPart and implements the following interfaces:

  • IEditingDomainProvider
  • ISelectionProvider
  • IMenuListener
  • IViewerProvider
  • IGotoMarker


One idea is to move all the ISelectionProvider relevant methodes into a separate super class and extend the editor class with it. (e.g. SelectionProviderEditorPart )


Because each standard EMF editor uses a AdapterFactoryEditingDomain to track the changes in the model, IHMO it make sense to define a abstract super class with some further standard definitions.

Here some ideas of this (see AbstractEMFEditorPart )

  • the definition of AdapterFactoryEditingDomain and ComposedAdapterFactory
  • provide a standard implementation of getAdapter
  • add getPropertySheetPage and getContentOutlinePage
  • a generic implementation of ContentPropertySheetPage instead to define always an anonym class
  • implement the IEditingDomainProvider interface

Problem Indicator

The generated ProblemIndicationAdapter class is already more or less independent form the rest of the editor. Therefor is is one of the first classes to extract and to generalize.

The idea for other stuff related to this topic is to move it in a separate class ProblemIndication

  • resourceToDiagnosticMap
  • markerHelper
  • updateProblemIndication
  • updateProblemIndication()

at least for the major parts.

Resource Management

Next big topic is resources. e.g. for the JFace text editor environment a document provider existes. A document is in this context the model part of the MVC and the document provider a special part of the controller. If the EMF model itself is here the model the editor act as an controller. IMHO the resource management (e.g. save) should bin i a sperate class. Several parts of this can be generalize ( AbstractResourceManager)