Jump to: navigation, search

Difference between revisions of "Talk:EMF/SinglePageEditor"

(Class definition)
Line 13: Line 13:
 
== Class definition  ==
 
== Class definition  ==
  
As you can see extends the generated file directly the MultiPageEditorPart.
+
As you can see the editor extends directly the MultiPageEditorPart and implements the following interfaces:
Therefor it implements (simple) interfaces like ISelectionProvider.
+
 
 +
* IEditingDomainProvider -
 +
* IMenuListener
 +
* IViewerProvider
 +
* IGotoMarker
 +
 
 +
and
 +
 
 +
=== ISelectionProvider ===
 +
 
 +
One idea is to move all the ISelectionProvider relevant methodes into a separate super class extend the editor class for it.
 +
(e.g. [http://code.google.com/a/eclipselabs.org/p/emf/source/browse/org.eclipselabs.emf.addon/src/org/eclipselabs/emf/addon/editor/SelectionProviderEditorPart.java SelectionProviderEditorPart] )

Revision as of 08:33, 3 January 2011

This page shall provide a discussion about the EMF Editor and about some improvements:

Please try to reflect the structure of the main page and please explain the current situation on the main page before starting a discussion about:

Files

Classes

The code generator produces just 4 classes. That is nice in the first place because you get fast a overview on all but if you take a look into the editor class (the first and the second time) it is almost unmanageable.

There is so many stuff included ....

Class definition

As you can see the editor extends directly the MultiPageEditorPart and implements the following interfaces:

  • IEditingDomainProvider -
  • IMenuListener
  • IViewerProvider
  • IGotoMarker

and

ISelectionProvider

One idea is to move all the ISelectionProvider relevant methodes into a separate super class extend the editor class for it. (e.g. SelectionProviderEditorPart )