Skip to main content
Jump to: navigation, search

Difference between revisions of "Orion/ESLint"

(Best Practices)
(Rules)
Line 2: Line 2:
  
 
== Rules ==  
 
== Rules ==  
The following table describes all of the rules currently available in Orion and ones that we plan to add in the future.
+
The following sections describe all of the rules currently available in Orion and ones that we plan to add in the future.
 
+
Rules that are currently available are <del>struck out</del>.
+
  
 
=== Potential Programming Problems ===
 
=== Potential Programming Problems ===
Line 17: Line 15:
 
! style="background:#efefef;" width=40% | Details
 
! style="background:#efefef;" width=40% | Details
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455253 no-comma-dangle]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455253 no-comma-dangle]
 
| Ignore
 
| Ignore
 
| 8.0
 
| 8.0
Line 23: Line 21:
 
| Flags trailing commas in object expressions.
 
| Flags trailing commas in object expressions.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455250 no-cond-assign]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455250 no-cond-assign]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 29: Line 27:
 
| Flags assignment in an <code>if/while/do..while/for</code> condition.
 
| Flags assignment in an <code>if/while/do..while/for</code> condition.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455371 no-console]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455371 no-console]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 35: Line 33:
 
| Flags the use of console in browser-based code
 
| Flags the use of console in browser-based code
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455680 no-constant-condition]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455680 no-constant-condition]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 41: Line 39:
 
| Flags the use of a constant as a conditional expression
 
| Flags the use of a constant as a conditional expression
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429690 no-debugger]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429690 no-debugger]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 47: Line 45:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=428430 no-dupe-keys]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=428430 no-dupe-keys]
 
| Error
 
| Error
 
| 6.0
 
| 6.0
Line 53: Line 51:
 
| Flags object literals that contain the same key more than once.
 
| Flags object literals that contain the same key more than once.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=439366 no-empty-block]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=439366 no-empty-block]
 
| Warning
 
| Warning
 
| 7.0
 
| 7.0
Line 59: Line 57:
 
| Flags an empty block like <code>if (something) { }</code>.
 
| Flags an empty block like <code>if (something) { }</code>.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=428040 no-extra-semi]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=428040 no-extra-semi]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0
Line 65: Line 63:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455391 no-regex-spaces]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455391 no-regex-spaces]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 71: Line 69:
 
| Flags regular expressions that have two or more subsequent spaces.
 
| Flags regular expressions that have two or more subsequent spaces.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455354 no-reserved-keys]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455354 no-reserved-keys]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 77: Line 75:
 
| Checks to see if a JavaScript reserved word is being used as a property key
 
| Checks to see if a JavaScript reserved word is being used as a property key
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=426723 no-sparse-arrays]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=426723 no-sparse-arrays]
 
| Warning
 
| Warning
 
| 8.0
 
| 8.0
Line 83: Line 81:
 
| Flags sparse arrays with null elements
 
| Flags sparse arrays with null elements
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=436986 no-unreachable]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=436986 no-unreachable]
 
| Error
 
| Error
 
| 6.0
 
| 6.0
Line 89: Line 87:
 
| Flags statements that occur after a <code>return</code>, <code>throw</code>, etc.
 
| Flags statements that occur after a <code>return</code>, <code>throw</code>, etc.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429711 use-isnan]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429711 use-isnan]
 
| Error
 
| Error
 
| 6.0
 
| 6.0
Line 118: Line 116:
 
|-
 
|-
  
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429722 curly]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429722 curly]
 
| Ignore
 
| Ignore
 
| 6.0
 
| 6.0
Line 124: Line 122:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 eqeqeq]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 eqeqeq]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0
Line 132: Line 130:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=424128 missing-doc]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=424128 missing-doc]
 
| Ignore
 
| Ignore
 
| 5.0
 
| 5.0
Line 144: Line 142:
 
| Flags missing documentation for parameters, returns, throws, etc on function declarations and function expressions when they appear as object properties
 
| Flags missing documentation for parameters, returns, throws, etc on function declarations and function expressions when they appear as object properties
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=460976 no-caller]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=460976 no-caller]
 
| Error
 
| Error
 
| 9.0
 
| 9.0
Line 150: Line 148:
 
| Flags references to <code>arguments.callee</code> and <code>arguments.caller</code>.
 
| Flags references to <code>arguments.callee</code> and <code>arguments.caller</code>.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429702 no-eval]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429702 no-eval]
 
| Ignore
 
| Ignore
 
| 6.0
 
| 6.0
Line 156: Line 154:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429815 no-fallthrough]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429815 no-fallthrough]
 
| Error
 
| Error
 
| 6.0
 
| 6.0
Line 162: Line 160:
 
| Flags a fallthrough case within a <code>switch</code> statement, unless it is explicitly commented.
 
| Flags a fallthrough case within a <code>switch</code> statement, unless it is explicitly commented.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429707 no-implied-eval]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429707 no-implied-eval]
 
| Ignore
 
| Ignore
 
| 6.0
 
| 6.0
Line 168: Line 166:
 
| Flags calls to the string-argument form of <code>setTimeout</code> and <code>setInterval</code>, which implicitly perform <code>eval</code>. This rule logic was merged to be part of the <b>no-eval</b> rule.
 
| Flags calls to the string-argument form of <code>setTimeout</code> and <code>setInterval</code>, which implicitly perform <code>eval</code>. This rule logic was merged to be part of the <b>no-eval</b> rule.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=455643 no-iterator]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=455643 no-iterator]
 
| Error
 
| Error
 
| 8.0
 
| 8.0
Line 174: Line 172:
 
| Flags use of __iterator__ as an identifier name or property key.
 
| Flags use of __iterator__ as an identifier name or property key.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-array]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-array]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 180: Line 178:
 
| Flags <code>new Array()</code>.
 
| Flags <code>new Array()</code>.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-func]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-func]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 186: Line 184:
 
| Flags <code>new Function()</code>.
 
| Flags <code>new Function()</code>.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-object]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-object]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 192: Line 190:
 
| Flags <code>new Object()</code>.
 
| Flags <code>new Object()</code>.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-wrappers]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429817 no-new-wrappers]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 206: Line 204:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-redeclare]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-redeclare]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0
Line 218: Line 216:
 
| Flags comparisons where the left- and right-hand sides are the same.
 
| Flags comparisons where the left- and right-hand sides are the same.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=438319 no-shadow]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=438319 no-shadow]
 
| Warning
 
| Warning
 
| 8.0
 
| 8.0
Line 224: Line 222:
 
| Flags variables that have the same name as a variable declared in an upper scope.
 
| Flags variables that have the same name as a variable declared in an upper scope.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=461321 no-shadow-global]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=461321 no-shadow-global]
 
| Warning
 
| Warning
 
| 9.0
 
| 9.0
Line 230: Line 228:
 
| Flags variables that have the same name as a variable declared in the global scope or specified environments.
 
| Flags variables that have the same name as a variable declared in the global scope or specified environments.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-undef]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-undef]
 
| Error
 
| Error
 
| 5.0
 
| 5.0
Line 238: Line 236:
 
* Predefined environments (eg. '''node''', '''browser''') can be set in the /*jslint */ block.
 
* Predefined environments (eg. '''node''', '''browser''') can be set in the /*jslint */ block.
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=427310 no-unused-params]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=427310 no-unused-params]
 
| Warning
 
| Warning
 
| 6.0
 
| 6.0
Line 244: Line 242:
 
| Flags parameters in function declarations / expressions if they are not being used
 
| Flags parameters in function declarations / expressions if they are not being used
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-unused-vars]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-unused-vars]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0
Line 250: Line 248:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-use-before-define]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=414779 no-use-before-define]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0
Line 262: Line 260:
 
| Treated as fatal parse error in JSLint.
 
| Treated as fatal parse error in JSLint.
 
|-
 
|-
!| <del>[http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f61bdaf06ac2f40eaca4daed39520cd60c41f5f3 radix]</del>
+
!| [http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f61bdaf06ac2f40eaca4daed39520cd60c41f5f3 radix]
 
| Warning
 
| Warning
 
| 8.0
 
| 8.0
Line 268: Line 266:
 
| Warns when parseInt() called without the 2nd parameter (radix).
 
| Warns when parseInt() called without the 2nd parameter (radix).
 
|-
 
|-
!| <del>[http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6e517847ef0742b090130748fb9a0329d33e16bf throw-error]</del>
+
!| [http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6e517847ef0742b090130748fb9a0329d33e16bf throw-error]
 
| Warning
 
| Warning
 
| 7.0
 
| 7.0
Line 292: Line 290:
 
| Flags String literals that are not properly NLS'd
 
| Flags String literals that are not properly NLS'd
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=429801 new-parens]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=429801 new-parens]
 
| Error
 
| Error
 
| 6.0
 
| 6.0
Line 310: Line 308:
 
| &nbsp;
 
| &nbsp;
 
|-
 
|-
!| <del>[https://bugs.eclipse.org/bugs/show_bug.cgi?id=427930 semi]</del>
+
!| [https://bugs.eclipse.org/bugs/show_bug.cgi?id=427930 semi]
 
| Warning
 
| Warning
 
| 5.0
 
| 5.0

Revision as of 12:30, 10 March 2015

Orion 5.0 moved to ESLint as the validator that ships with Orion. This page captures ongoing issues.

Rules

The following sections describe all of the rules currently available in Orion and ones that we plan to add in the future.

Potential Programming Problems

These rules report about problems with your code that might have undesired or incorrect results. Warnings from these rules should be addressed.

Rule Default Severity Available Since Problem Message Details
no-comma-dangle Ignore 8.0 Trailing commas in object expressions are discouraged. Flags trailing commas in object expressions.
no-cond-assign Error 8.0 Expected a conditional expression and instead saw an assignment. Flags assignment in an if/while/do..while/for condition.
no-console Error 8.0 Discouraged use of console in browser-based code. Flags the use of console in browser-based code
no-constant-condition Error 8.0 Discouraged use of constant as a conditional expression. Flags the use of a constant as a conditional expression
no-debugger Warning 6.0 debugger' statement use is discouraged.  
no-dupe-keys Error 6.0 Duplicate object key '{key}'. Flags object literals that contain the same key more than once.
no-empty-block Warning 7.0   Flags an empty block like if (something) { }.
no-extra-semi Warning 5.0 Unnecessary semicolon.  
no-regex-spaces Error 8.0 Avoid using multiple spaces in regular expressions. Use ' {${0}}' instead. Flags regular expressions that have two or more subsequent spaces.
no-reserved-keys Error 8.0 Reserved words should not be used as property keys. Checks to see if a JavaScript reserved word is being used as a property key
no-sparse-arrays Warning 8.0 Sparse array declarations should de avoided. Flags sparse arrays with null elements
no-unreachable Error 6.0 Unreachable code. Flags statements that occur after a return, throw, etc.
use-isnan Error 6.0 Use the isNaN function to compare with NaN.  

Best Practices

These rules are not necessarily problem with your code, but are warnings that you might be doing something you probably should not be.

Rule Default Severity Available Since Problem Message Details
block-scoped-var Error - '{variable}' is already defined.
  • Occurs when a function-scoped variable is treated as if it was block scoped.
  • ESLint calls this error '{variable} used outside of binding context.'
curly Ignore 6.0 Statements should be enclosed in braces.  
eqeqeq Warning 5.0
  • Expected '===' and saw '=='.
  • Expected '!==' and saw '!='.
 
missing-doc Ignore 5.0 "Missing documentation for function '{name}.'" Flags missing documentation nodes on function declarations and function expressions when they appear as object properties
missing-doc-items Ignore -   Flags missing documentation for parameters, returns, throws, etc on function declarations and function expressions when they appear as object properties
no-caller Error 9.0 arguments.{callee, caller} is deprecated. Flags references to arguments.callee and arguments.caller.
no-eval Ignore 6.0 'eval' function calls are discouraged.  
no-fallthrough Error 6.0 Switch case may be entered by falling through previous case. If intended, add a new comment //$FALL-THROUGH$ on the line above Flags a fallthrough case within a switch statement, unless it is explicitly commented.
no-implied-eval Ignore 6.0 Implicit 'eval' function calls are discouraged. Flags calls to the string-argument form of setTimeout and setInterval, which implicitly perform eval. This rule logic was merged to be part of the no-eval rule.
no-iterator Error 8.0 Discouraged __iterator__ property use. Flags use of __iterator__ as an identifier name or property key.
no-new-array Warning 6.0 Use the array literal notation []. Flags new Array().
no-new-func Warning 6.0 The Function constructor is eval. Flags new Function().
no-new-object Warning 6.0 Use the object literal notation {}. Flags new Object().
no-new-wrappers Warning 6.0 Do not use {String, Number, Boolean, Math, JSON} as a constructor. Flags new applied to any of those.
no-proto Error -
  • Reserved name '__proto__' should not be assigned."
  • 'Reserved name '__proto__' should not be used as a key."
 
no-redeclare Warning 5.0 '{a}' is already defined. Usually results from having two for loops in the same function that share a loop variable declaration like var i=....
no-self-compare Error -   Flags comparisons where the left- and right-hand sides are the same.
no-shadow Warning 8.0 '{a}' is already declared in the upper scope. Flags variables that have the same name as a variable declared in an upper scope.
no-shadow-global Warning 9.0 '{a}' shadows a global member. Flags variables that have the same name as a variable declared in the global scope or specified environments.
no-undef Error 5.0 '{variable}' is not defined.
  • Flags references to a global variable that is not listed in a /*global*/ or /*globals*/ block.
  • Predefined environments (eg. node, browser) can be set in the /*jslint */ block.
no-unused-params Warning 6.0 "Parameter '{param}' is not used." Flags parameters in function declarations / expressions if they are not being used
no-unused-vars Warning 5.0 Function declares unused variable '{a}'.  
no-use-before-define Warning 5.0 '{a}' was used before it was defined.  
no-with Warning - Expected an identifier and instead saw 'with'. Treated as fatal parse error in JSLint.
radix Warning 8.0 Missing radix parameter. Warns when parseInt() called without the 2nd parameter (radix).
throw-error Warning 7.0   Flags code that throws a non-Error, eg. throw "a problem occurred";

Code Style

These rules are not problems in any way but will warn based on certain accepted styles for coding.

Rule Default Severity Available Since Problem Message Details
missing-nls Ignore -   Flags String literals that are not properly NLS'd
new-parens Error 6.0 Missing parentheses invoking constructor. Flags new Whatever
no-mixed-returns Error -   Flags functions that return more than one kind of item, for example returning String and Object
no-undef-init Warning - It is not necessary to initialize '{variable}' to 'undefined'.  
semi Warning 5.0 Missing semicolon.  

Implementing a new rule

This section explains how to implement a new linting rule. For brevity, all paths are given relative to bundles/org.eclipse.orion.client.javascript/web/ in the client repo.

First, create the tests and rule:

  1. Create a new test file for the rule at: /eslint/tests/lib/rules/{rule-name}.js.
  2. Link your test to the suite in /eslint/tests/load-tests.js.
  3. Implement the actual logic for your rule in /eslint/lib/load-rules-async.js.

At this point you should run the JS bundle tests and ensure your rule works as intended. To get your rule running in the Orion product's validator, there are additional steps:

  1. Create strings for the validation message(s) generated by your rule in /javascript/nls/root/problems.js.
  2. Create a short string describing what your rule does in /javascript/nls/root/messages.js.
  3. Add an entry to the orion.core.setting declaration in /javascript/plugins/javascriptPlugin.js. This allows your rule to be configured from the JS validator settings page. Make sure it references the same nameKey used in messages.js.
  4. Add a config entry for your rule to the default ESLint config object in /javascript/validator.js.
  5. Add your rule to the #updated() handler in /javascript/validator.js.

Reload the JS plugin, and your rule should now be configurable from the Settings page, and properly set up for translation too.

Tests

  • Every rule needs extensive unit tests.
  • Unit tests should use Mocha.

Running the tests

  • To run the ESLint tests as part of the main JavaScript tests suite load {orion-server-url}/javascript/js-tests/JsMochaSuite.html in your web browser.
  • To run just the ESLint rule tests, load {orion-server-url}/js-tests/javascript/JsMochaSuite.html?grep=ESLint%20Rule%20Tests in your browser.
  • To run just the ESLint core tests, load {orion-server-url}/js-tests/javascript/JsMochaSuite.html?grep=ESLint%20Core%20Tests in your browser.
  • To run only a subset of the tests, add ?grep=ESLint%20Rule%20Tests onto the test page URL.

See Mocha usage options for more options.

User interface

  • Should we have a UI for configuring what rules are active? bug 424268.
  • Should we try to support .eslintrc? This would be an ideal project-scope setting.
  • Should we try to honor equivalent JSLint/JSHint flags when possible? For example /*jslint eqeqeq:false */ could disable the eqeqeq rule on a per-file basis.
    • ESLint now has its own syntax for this: /*eslint ..*/, which we are using instead.

i18n

We need to support i18n. Pre-req is bug 422278 (orion.edit.validator support for i18n).

Back to the top