Difference between revisions of "Orion/Coding conventions"

From Eclipsepedia

Jump to: navigation, search
(JavaScript)
m (Writing a class)
Line 211: Line 211:
 
  };
 
  };
  
The <code>mixin()</code> function from the <code>orion/objects</code> module can be helpful if you have a lot of properties to add to the prototype. Using <code>mixin</code>, the above example would look like:
+
The <code>mixin()</code> function from the <code>orion/objects</code> module can make your code more compact when you have a lot of properties to add to the prototype. Using <code>mixin</code>, the above example would look like:
 
  function Duck(name) {
 
  function Duck(name) {
 
     this.name = name;
 
     this.name = name;

Revision as of 12:09, 31 January 2013

This is a draft work in progress. If you have suggestions on good naming practices for JavaScript, CSS, and HTML, please raise a discussion on the Orion mailing list.

Contents

JavaScript

Compatibility

In general, Orion's JavaScript code is targeted toward modern JS runtimes. This means you can (and should) use ECMAScript 5 features like Object.keys, Array.prototype.forEach, and so on. ECMAScript 6 features should not be used, as they are not yet widely supported.

Some of Orion's client bundles may have more strict requirements about what features are allowed. For example, the Orion Editor supports older browsers like Internet Explorer 8, and thus has to avoid most ES5 features (even Array.prototype.indexOf is not allowed in IE8).

References

General Guidelines

We highly recommend writing Orion code using the Orion IDE, as its built-in validator will catch a lot of possible coding errors and anti-patterns (like accidental globals, for example).

When in doubt about coding style, follow these general rules:

  • Favor ES5 features.
    • But don't use strict mode yet.
  • Favor W3C APIs.
    • If a well-supported spec exists, use it.
    • If a decent-looking spec exists but it isn't well-supported, write a shim for it, then use it.

Modules

  • Your code should be written as an AMD module using define.
  • Use only one module per file.
  • If your code depends on other modules or files, that relationship should be expressed as AMD dependencies (see below).

✔ This module depends on Deferred and xhr:

define(['orion/Deferred', 'orion/xhr'], function(Deferred, xhr) {
    // Use Deferred and xhr here.
});
  • Use the UMD authoring pattern if your module might need to run in non-AMD environments (like CommonJS modules or plain <script> tags).
    • See Deferred.js for an example of a file written using UMD.
    • In the no-module case, your code should place its exports inside the orion property of the root or global object.

Globals

Your code should not export any* globals. Pay close attention to the problem markers in the Orion editor. Implied globals will be flagged as an error.

✘ Code that creates an implicit global variable. Don't do this.

for (i = 0; i < 10; i++) {       // ERROR: implied global `i`
    console.log("Hello world");
}
  • If your code depends on globals (eg. define, require, jQuery) or browser objects (eg. document, setTimeout), they should be explicitly listed in a /*global */ section near the top of the file. This allows them to be statically checked for misspellings by the validator. At minimum, you should have /*global define*/.

✔ Here we declare the document and define globals:

/*global define document*/
define([], function() {
    // Use document
    document.createElement('div');
});
* Shims are an exception to the "no globals" rule. See URL-shim.js for an example.

Internal data

All member variables starting with an underscore ('_') or having the @private jsdoc tag, are internal and should not be referenced by clients. Such variables are subject to change or removal at any time.

Arrays

Testing if a value is an array

✔ Do this:

Array.isArray(value);

Looping through elements

✔ Use Array.prototype.forEach:

array.forEach(function(item) {
    // ...
});

✘ Don't use a loop variable. It is more prone to typing errors, and hinders refactoring by polluting the containing function's scope with i.

for (var i=0; i < array.length; i++) {
    // ...
}

Having said that, a typical for loop will perform faster than the forEach function. Performance-critical code may need to use for, but it's best to use forEach until you've demonstrated that it's too slow for your needs.

✘ Don't treat an array like an object. Never do this:

for (var i in array) {
    // ...
}

Searching for an element with strict-equals

✔ Use Array.prototype.indexOf

var index = array.indexOf(item);
if (index !== -1) {
   console.log("Found it!");
}

✘ Don't do a manual search:

for (var i=0; i < array.length; i++) {
    if (array[i] === item) {
       console.log("Found it!");
       break;
    }
}

Applying a transformation to an array

✔ Use Array.prototype.map.

Deciding if an element satisfies a condition

✔ Use Array.prototype.some.

Also note that some's early-exit behavior (when the callback returns true) can be used to replace a manual for .. break search for an element.

Determining if every element satisfies a condition

✔ Use Array.prototype.every.

Removing elements that satisfy a condition

✔ Use Array.prototype.filter.

Objects

Testing equality

In comparisons, always use the strict equality === and strict inequality !== operators. This makes your code's intent clear to other readers. While the nonstrict equality == may seem like a nice shortcut, it performs type conversions that can be surprising.

✘ For example, a nonstrict comparison against null doesn't behave like you might expect:

if (value == null) {
    console.log("value is null... or is it?");
    // do stuff with value
}

Since undefined == null, the above code allows value to be undefined and pass the if-test, which may cause problems later on.

Testing for objectness

✔ Do this:

if (value !== null && typeof value === "object") {
    // use value as an object
    Object.keys(value);
}

The null check is required, because otherwise null could sneak into the Object.keys call and cause an error. (Recall that typeof null === "object").

Testing for definedness

When writing a function that accepts a variable number of arguments (optional parameters), we sometimes want to check if a parameter is not undefined.

✔ Compare the parameter's type against "undefined":

function variadic(param) {
  if (typeof param === "undefined") {
      console.log("Called with no arguments");
  } else {
      console.log("Called with 1 argument");
  }
}

But why not just compare against undefined? Well, undefined is actually a reference to the global window.undefined property, not a primitive value. (Older JS engines would actually allow undefined to be overwritten, although ES5 has thankfully prevented that.) Because undefined is a legal variable name, it makes your code vulnerable to accidental lexical closures if someone else has foolishly created an in-scope variable named undefined:

✘ A broken comparison against undefined:

function() {
    var undefined = true;  // Never do this

    function wrong(param) {
        if (param === undefined) {
            console.log("param is undefined... or is it?");
        }
    }
    wrong();     // does nothing
    wrong(true); // prints "param is undefined... or is it?"
}

Looping through an object's properties

✔ Use Object.keys:

Object.keys(object).forEach(function(property) {
    console.log('property: ' + property);
})

✘ Don't do it this way. While the code is technically correct, Object.keys is clearer and more concise:

for (var property in object) {
    if (Object.prototype.hasOwnProperty.call(object, property)) {
        console.log('property: ' + property);
    }
}

✘ Don't do this. It iterates through all properties in object's prototype chain, which is almost never what you want:

for (var property in object) {
    console.log('property: ' + property);
}

Functions

Attaching a particular this-context to a function

✔ Use Function.prototype.bind:

var context = { myfield: "Hello world" };
var func = function() {
    return this.myfield;
};
var boundFunction = func.bind(context);
boundFunction(); // Hello world

bind is especially useful when dealing with event listeners, which need to be passed around to addEventListener methods but retain their this-context:

function Widget() {
    this.clickCount = 0;
    document.getElementById("myButton").addEventListener("click", this.handleClick.bind(this)); // handleClick always gets the right "this"
}
Widget.protoype.handleClick = function() {
    this.clickCount++;
    alert("You clicked me " + this.clickCount + " times");
};

Classes

Writing a class

The Orion approach to writing "classes" is fairly straightforward. It doesn't require any fancy libraries, just constructor functions and prototypes:

function Duck(name) {
    this.name = name;
}
Duck.prototype.greet = function() {
    console.log("Quack quack, my name is " + this.name);
};

The mixin() function from the orion/objects module can make your code more compact when you have a lot of properties to add to the prototype. Using mixin, the above example would look like:

function Duck(name) {
    this.name = name;
}
objects.mixin(Duck.prototype, {
    greet: function() {
        console.log("Quack quack, I'm a duck named " + this.name);
    }
    //, more properties here...
});

Subclassing

To extend a class and add additional properties, we use a pattern similar to the code shown below. The subclass's constructor explicitly invokes the superclass's constructor to perform the usual Duck initialization, and then performs more initialization specific to the subclass. Note how Object.create is used to extend the superclass's prototype object.

function SeaDuck(name, swimSpeed) {
    Duck.call(this, name);      // or Duck.apply(this, arguments)
    this.swimSpeed = swimSpeed;
}
SeaDuck.prototype = Object.create(Duck.prototype);
SeaDuck.prototype.swim = function() {
    console.log(this.name + " is swimming at a speed of " + this.swimSpeed);
};

Creating a dictionary

To create a dictionary (a map with string keys), we can use an object.

✔ Do this:

var map = Object.create(null);

✔ Or this:

var map = { };

Checking if a key is present

✔ Use hasOwnProperty to determine if a given key is present in the map:

if (Object.prototype.hasOwnProperty.call(map, key)) {
    console.log("The key " + key + " was found!"
} 

✘ Don't use a truthiness check to determine key presence:

if (map[key]) {
    console.log("The key " + key + " was found!");
}

The truthiness check will give false negatives if the key's value happens to be falsey (like 0 or "").

✘ But even correctly handling falsey values won't save the [] operator. Don't do this either:

if (typeof map[key] !== "undefined") {
    console.log("The key " + key + " was found!");
}

While the code may appear correct, in many JS runtimes map[key] will return a reference to the map's prototype object when key equals the nonstandard property name __proto__. This will again give false positives. Rather than try to work around the __proto__ special case, it's best to avoid the [] operator entirely and use hasOwnProperty.

Writing an event emitter

Use the orion/EventTarget mixin to inject event behavior into an object. After calling attach(), your object implements the EventTarget DOM3 interface, and can dispatch events to listeners.

define(["orion/EventTarget"], function(EventTarget) {
    var myobject = {};
    EventTarget.attach(myobject);

    myobject.addEventListener("coolevent", function(event) {
        console.log("Listener received an event");
    });
    myobject.dispatchEvent({ type: "coolevent" }); // Every event must have a type. Other fields optional.
});

To add event behavior to a class, call attach inside your constructor:

function Duck(name) {
    this.name = name;
    EventTarget.attach(this);
}
new Duck("Howard").dispatchEvent({ type: "quack" });

Asynchronous operations

Use orion/Deferred to manage asynchronous operations. Its API is documented here.

XMLHttpRequest and Ajax

In most cases it's convenient to use orion/xhr, which wraps the browser's native XMLHttpRequest into a promise. The xhr API is documented here.

define["orion/xhr"], function(xhr) {
    xhr("GET", "/index.html").then(
        function(xhrResult) {
            console.log("Got response: " + xhrResult.response);
        },
        function(xhrResult) {
            console.log("An error occurred: " + xhrResult.error);
        });
});

URLs

Orion provides a shim for the W3C URL API. Load the shim in your module, and then call the window.URL constructor. You should always use the URL methods, rather than concatenate and encode strings by yourself.

✔ Do this:

define(["orion/URL-shim"], function() {
    var url = new URL("http://foo.com");
    url.query.set("param1", "first value");
    url.query.set("param2", "second value");
    var myurl = url.href; // http://foo.com/?param1=first%20value&param2=second%20value
});

✘ Don't do this:

 var myurl = "http://foo.com/?param1=" + encodeURIComponent("first value") + "&" + encodeURIComponent("second value");

Consider also using the orion/URITemplate module, which implements the URI Template spec.


Services

The DOM location of service objects is not defined. All services must be accessed via the service registry using the service's symbolic id. While concrete service implementations may be found in the DOM, such object names are not API and are subject to change at any time. Service symbolic ids follow the Reverse DNS naming convention (like Java packages).

JSON

Server requests and responses are represented by default as JSON objects. Object member names use title case ("Name", "ChildrenLocation", etc).

JS Documentation

All JavaScript API uses JSDoc syntax. Orion code is written as self-contained AMD modules that don't expose global objects. So rather than tagging the actual objects with documentation, we tend to use JSDoc tags to construct virtual "classes" corresponding to a module's exported API. These virtual tags can appear almost anywhere in the source code, but it's best to keep them close to the functions that they represent.

The principal doc tags used are:

@param
Documentation of method parameters. See TagParam in the jsdoc wiki for further details.
@name
For specifying class names. The class name should match the RequireJS module name.
@lends
For specifying what class a prototype contributes to
@class
Indicates that this comment represents a class definition. The text of the @class tag becomes the class description.
@description
A detailed description of what this class, function, or field does. The first sentence will be used as a one-line summary of the class constructor. If @description is not given explicitly, the header of the comment is used.

See also the complete JSDoc tag reference.

Documenting a class

JSDoc doesn't distinguish between class documentation and constructor documentation: they both go into a single comment block. So to document a class, we have a comment containing @name, @class, and @description tags, plus all the normal method tags (@param and so on).

/**
 * @name orion.MyClass
 * @class Class header summary of MyClass.
 * @description One-line summary of MyClass.
 * Longer description of MyClass, which can include code examples (in <code> tags),
 * HTML and links to other docs (using @see). This also serves as documentation 
 * for the constructor function.
 * 
 * @param {String} param1 The widget to frob.
 * @param {Boolean} [param2=false] Whether the flux capacitor should be quuxed.
 */
function MyClass(param1, param2) {
    // ...
}

Methods

Because JavaScript's prototypal inheritance doesn't quite fit the class-oriented model of JSDoc, there's a few different approaches for documenting methods, depending on how your "class" is built. The general pattern for a method uses the tags:

@name
Gives name of this method. This can be fully-qualified (in which case . indicates static membership, and # indicates instance membership).
@function
Tells JSDoc we're documenting a function (otherwise it will assume a field).
@param {Type} paramName comment
Documents a required parameter. May appear multiple times.
@param {Type} [optParamName=defaultValue] comment
Documents an optional parameter, and its default value. May appear multiple times.
@returns {Type} comment
Documents the function's return value.

You may also come across these tags in the source. Note that both of these tags are made redundant by proper use of @name and @function:

@memberOf
Writing @name orion.MyClass#foo is equivalent to combining @name foo and @memberOf orion.MyClass.prototype
@methodOf
Equivalent to combining @memberOf and @function.
Per-instance method

If you're injecting methods into each instance of your class, a method doc comment looks like this:

function ServiceTracker() {
    /**
     * Returns service references to the services that are being tracked.
     * @name orion.ServiceTracker#getServiceReferences
     * @function
     * @returns {orion.serviceregistry.ServiceReference[]} References to all services that
     * are being tracked by this ServiceTracker.
     */
    this.getServiceReferences = function() {
        // ...
    };
}
Prototype method (mixin lends)

This is for when your class mixes in (or directly uses) an object literal for its prototype. We tag the object with @lends, causing JSDoc to add all the literal's fields into the class prototype. Our method docs can then omit the @function and @name tags, because JSDoc already knows the containing class and the type of member.

function ServiceTracker() {
    // ...
}
ServiceTracker.prototype = /** @lends orion.MyClass.prototype */ {
    /**
     * Called to customize a service object being added to this ServiceTracker.
     * @param {orion.serviceregistry.ServiceReference} serviceRef The reference to the service being added.
     * @returns {Object} The service object to be tracked for the given service reference.
     */
    addingService: function(serviceRef) {
        // ...
    }
    //, Additional prototype methods can go here.
};
Prototype method (assignment)

When assigning methods directly to our class's prototype, JSDoc falls over somewhat, and can't infer the containment or the member type. So we need to explicitly place each method into the class using @name, and function-ify it with @function:

function ServiceTracker() {
}
/**
 * Called to customize a service object being added to this ServiceTracker.
 * @name orion.ServiceTracker#addingService
 * @function
 * @param {orion.serviceregistry.ServiceReference} serviceRef The reference to the service being added.
 * @returns {Object} The service object to be tracked for the given service reference.
 */
ServiceTracker.prototype.addingService = function(serviceRef) {
    // ...
};
Static methods

To indicate that a method is static, make it a member of the class itself, rather than the class's prototype:

/**
 * @name orion.Deferred.all
 * @function
 */
 function all(promises) {
     // ...
 }

JSDoc also has a @static tag, but you probably won't need it.

Types

Any type known to the JSDoc parser can appear inside the curly braces of a @param or @return tag. A type can be a fully-qualified class name, or a global JavaScript object like Boolean, String, Function, etc. The Orion source generally uses the capitalized object wrapper names to refer to primitive types: for example we say String rather than string, Boolean rather than boolean, and so on.

JSDoc also understands array types: append [] after the name of any type to indicate that it's an array.

/**
 * @param {orion.Promise[]} promises
 */

To indicate that a param or return type takes one of a set of types, join the types with a |:

/**
 * @param {String|Element} elementOrDomId
 */

When a type can be "anything", we represent it as {Object}.

Fields

HTML

None of the HTML in Orion is API. The existence and contents of any HTML file is subject to change at any time. If you see something in Orion's HTML files that you need in your application, make your own copy.

HTML Fragments and Templates

When writing a visual component, it's often convenient to define a fragment of HTML that serves as the component's template. There are several ways to go about this. This section discusses when you might want to use the different approaches, and what our long term direction is.

Where is the fragment defined?

A fragment is a little chunk of HTML that describes a component. There are a few choices in the mechanics of where a fragment is defined.

  • A fragment could be defined in js code as a string. Consider this snippet from the dialog prototype:
Dialog.prototype.TEMPLATE = 		
'<div class="dialog" role="dialog">' + //$NON-NLS-0$
	'<div class="dialogTitle layoutBlock"><span id="title" class="dialogTitleText layoutLeft"></span></div>' + //$NON-NLS-0$
	'<div class="layoutBlock"><hr/></div>' + //$NON-NLS-0$
	'<div id="dialogContent" class="dialogContent layoutBlock"></div>' + //$NON-NLS-1$ //$NON-NLS-0$
	'<div id="buttons" class="dialogButtons"></div>' + //$NON-NLS-1$ //$NON-NLS-0$
'</div>'; //$NON-NLS-0$

An advantage of this approach when using Orion to edit fragments is keeping the fragment close to the JavaScript code that is manipulating it or making assumptions about its structure. This is, of course, a tooling issue (not having split editors, or popping up references, etc.) The disadvantage is the noise created by concatenation, $NON-NLS markings, etc. This kind of code also tempts the developer to directly concatenate NLS message strings into the content, and that is a security risk (described later).

  • A fragment can be defined in an HTML file that is brought into the JavaScript module via a requirejs text! module. For example, the common page footer is defined in a footer.html file like this:
<footer id="footerContent" class="layoutBlock footerLayout" role="contentinfo">
	<!-- Requires some js code to bind the NLS variables  -->
	<div class="footerBlock">${Orion is in Beta. Please try it out but BEWARE your data may be lost.}</div>
	<div class="footerRightBlock">
		<a href="http://wiki.eclipse.org/Orion/FAQ" target="_blank">${FAQ}</a>
		<a href="https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Orion&version=1.0" target="_blank">${Report a Bug}</a>|
		<a href="http://www.eclipse.org/legal/privacy.php" target="_blank">${Privacy Policy}</a>|
		<a href="http://www.eclipse.org/legal/termsofuse.php" target="_blank">${Terms of Use}</a>|
		<a href="http://www.eclipse.org/legal/copyright.php" target="_blank">${Copyright Agent}</a>
	</div>
</footer>

Javascript code would refer to the fragment by the requireJS module name.

define(['i18n!orion/nls/messages', 'require', 'text!orion/banner/footer.html'],
function(messages, require, FooterFragment) {

// excerpt from common page code
var footer = document.getElementById("footer"); //$NON-NLS-0$
if (footer) {
	footer.innerHTML = FooterFragment;
}
  • A fragment can also be defined inside a template element. Orion provides a shim for the draft HTML Templates API that lets you define template elements. Templates are a promising approach for the following reasons:
    • if you use the fragment many times on a page, using a template means it will be parsed only once.
    • once parsed, you can make common, dynamic modifications to the template (binding variable values, etc.) only once.
    • the DOM structure behind a template is not associated with the document until a node is actually cloned. This means that if the template references network resources (such as an image URL), there will be no attempt to download the image until the template is actually cloned into a node and placed in the document.

If we used a template for the footer fragment, it would look like this instead. (Using a template for a footer that appears once is not necessarily a good idea, but this is shown to illustrate the difference in approach:)

<template id="footerTemplate">
   <footer id="footerContent" class="layoutBlock footerLayout" role="contentinfo">
	<!-- Requires some js code to bind the NLS variables  -->
	<div class="footerBlock">${Orion is in Beta. Please try it out but BEWARE your data may be lost.}</div>
	<div class="footerRightBlock">
		<a href="http://wiki.eclipse.org/Orion/FAQ" target="_blank">${FAQ}</a>
		<a href="https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Orion&version=1.0" target="_blank">${Report a Bug}</a>|
		<a href="http://www.eclipse.org/legal/privacy.php" target="_blank">${Privacy Policy}</a>|
		<a href="http://www.eclipse.org/legal/termsofuse.php" target="_blank">${Terms of Use}</a>|
		<a href="http://www.eclipse.org/legal/copyright.php" target="_blank">${Copyright Agent}</a>
	</div>
   </footer>
</template>

The JavaScript would look like this:

define(['i18n!orion/nls/messages', 'require', 'orion/HTMLTemplates-shim' 'template!orion/banner/footer.html'],  // note use of template! not text!
function(messages, require) {

var template = document.getElementById("footerTemplate");
var footer = document.getElementById("footer"); //$NON-NLS-0$
if (footer) {
	footer.appendChild(template.content.cloneNode());
}

The example above assumes that we have a requirejs plugin for parsing html files and building a template element. (Bug 395402). Until we have such a plugin, the template would have to be marked up in the page itself.

Inserting text fragments

As mentioned above, a template element is preferred for fragments repeated many times, or to delay/reduce the network traffic associated with associating a fragment with a document. However, our tooling for letting library modules bring in templates is not complete here. If you are using text fragments in library modules, or you have a "one-off" fragment, it is reasonable to insert the fragment into the DOM without using a template element. Suppose you have a text fragment you want to insert into the document. (You could have created this text fragment in the JavaScript as a string or imported as a text!myFragment module. It doesn't matter.)

To get it into the document you have several approaches:

innerHTML

If you have a node that is exclusive to the fragment, you can use the innerHTML of the node. The original footer example showed this.

define(['i18n!orion/nls/messages', 'require', 'text!orion/banner/footer.html'],
function(messages, require, FooterTemplate) {

// excerpt from common page code
var footer = document.getElementById("footer"); //$NON-NLS-0$
if (footer) {
	footer.innerHTML = FooterTemplate;
}

Of course, if there were any other nodes inside the footer DOM node, they would be removed.

createContextualFragment

Another approach, useful when you are adding a fragment to a parent and don't want to remove other child nodes, is to create a contextual fragment and then add it into the DOM as you would any other node. For example, this code adds a banner fragment as the first child of the document body.

define(['i18n!orion/nls/messages', 'require', 'text!orion/banner/banner.html'],
function(messages, require, BannerFragment) {
var range = document.createRange();
var parent = document.body;
range.selectNode(parent);
var headerFragment = range.createContextualFragment(BannerFragment);
		
if (parent.firstChild) {
	parent.insertBefore(headerFragment, parent.firstChild);
} else {
	parent.appendChild(headerFragment);
}

Security and Data Binding

Often, you'll want to bind some data to a fragment. For example, you might want to describe some text using its i18n/NLS message key name, which comes from a plug-in. Or perhaps the text in the template depends on some JSON property on the server. Regardless of how you created your fragment, you'll need to ensure that these strings are not bound directly as text in a fragment. They should be inserted as text nodes in the DOM. This restriction is necessary so that plugins or other external sources cannot insert arbitrary HTML into the page.

Do not concatenate variable strings into a fragment and insert into the document. Instead, a data binding approach should be used to refer to the values by their key. Strings can be bound to a fragment using the processTextNodes function in 'orion/webui/littlelib'. This utility allows you to refer to the strings in your template using variables, and DOM API will be used later to bind your string to the text node in the HTML. You may have noticed in the Orion footer example, we use ${variable} syntax in the markup. The user of such a fragment is responsible for providing the correct data binding object for processing the DOM elements.

define(['i18n!orion/nls/messages', 'require', 'orion/webui/littlelib','text!orion/banner/footer.html'],
function(messages, require, lib, FooterTemplate) {

// excerpt from common page code

var footer = lib.node("footer"); //$NON-NLS-0$
if (footer) {
	footer.innerHTML = FooterTemplate;
	// do the i18n string substitutions
	lib.processTextNodes(footer, messages);
}

This data binding approach can be used for any object, not just NLS message objects. When the DOM tree text nodes are processed, any nodes that have the ${variable} syntax will be considered to describe a property name. The text nodes containing the variables will be replaced with nodes containing matching property value found in the bound object. If no matching property is found, the original text remains.

CSS

We use the Orion editor to author .css files. Orion provides a built-in CSSLint validator which flags potential problems in your stylesheets.

CSS file structure

For each Orion page {page}.html, there is generally an associated {page}.css file in the same folder. The page CSS is for that page only, and should not be reused. Any reusable styling for common visual components should go in the bundles/org.eclipse.orion.client.ui/web/css/ folder.

Any stylesheets required by your page CSS should be loaded using @import. These @imports can be inlined by a CSS optimizer like RequireJS's. Do not @import external stylesheets (http://...), as those cannot be inlined.

Style tips

Use DOM structure selectors with caution

CSS provides a number of powerful selectors that act upon the DOM structure, like the type, descendent, and child selectors.

While these can be helpful, their overuse produces a page whose style is brittle and tightly coupled to the DOM structure, such that simple refactorings (adding a wrapper DIV around child elements, for example) completely break the page.

✘ A rule with many DOM selectors is brittle:

.mytable > div > div > label > span {
    font-weight: bold;
}

✔ Something like this is better:

.mytable span.emphasis {
    font-weight: bold;
}

Don't use unqualified tag selectors

The type selector matches any element with the given HTML tag name. In complex pages, these are prone to matching too much. They also hinder refactoring, as your stylesheet cannot safely be made reusable, and a reader of either the HTML or CSS has a difficult time determining just which elements you intend to match. Instead, consider a class selector.

✘ Don't use selectors that match an entire class name:

div {
    background-color: red;
}

✔ Instead, create a class selector that targets only the elements you want:

div.myclass {
    background-color: red;
}

The html and body elements are exceptions.

Avoid the ID selector

While necessary in the DOM, IDs should be avoided in stylesheets. IDs are the DOM equivalent of singletons, and targeting them prevents your styles from being reused on other elements. IDs should be regarded as an internal property of the HTML (or JavaScript), not an exported symbol to be styled. Instead of an ID, apply a class name to the DOM element you're trying to style, and use a class selector.

✘ Instead of this:

#content-title {
    text-shadow: white 0 1px 2px;
}

✔ …Use a class:

.content-title {
    text-shadow: white 0 1px 2px;
}

Java

Java code on the server follows the standard Eclipse Naming Conventions. The project short name is 'orion', so all server bundles and packages start with org.eclipse.orion.

Provisional API packages use the x-internal or x-friends manifest attribute, and do not have internal as a segment in the package name. Use of PDE API tools is highly recommended to ensure you are using supported API.

Copyrights

The Orion server source code is licensed under the Eclipse Public License. The standard Eclipse copyright header should be used for these source files.

The Orion client code (HTML, CSS, JavaScript), is licensed under both the Eclipse Public License and the Eclipse Distribution License. Here is a sample copyright header to use in JavaScript source files:

/******************************************************************************* 
 * Copyright (c) <date> <contributor name> and others.
 * All rights reserved. This program and the accompanying materials are made 
 * available under the terms of the Eclipse Public License v1.0 
 * (http://www.eclipse.org/legal/epl-v10.html), and the Eclipse Distribution 
 * License v1.0 (http://www.eclipse.org/org/documents/edl-v10.html). 
 * 
 * Contributors: <contributor name> - initial API and implementation 
 ******************************************************************************/