Skip to main content

Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

OAW Developer Guidelines

Revision as of 04:48, 9 May 2008 by Jan.gitpod.io (Talk | contribs) (→‎Logging and Tracing)

oAW Developer Guidelines

The purpose of this page is to

  • centrally collect suggestions for policies and procedures for the development of openArchitectureWare 5
  • agree upon policies and procedures
  • provide new developers an easier start

Feel free to add your own suggestions and mark them with your name to make discussions easier.

Don't correct other user's suggestions (except typos). We should first collect ideas and then discuss critical issues.

It's not our objective to establish a heavy-weight process for oAW development. Make sure your suggestions are not to restrictive to keep oAW agile.

If some of these suggestions appear trivial or common sense to you, they might not be for others (especially new developers). So please ignore them gracefully unless you disagree.


Platform

  • Code must comply to Java 5 --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • In order to ensure we only use Java 5, all projects get a project specific compiler setting. --Peter.friese.itemis.de 10:03, 30 April 2008 (EDT)
  • Target platform is Eclipse 3.3 (4?) --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • Target standalone environment is Equinox, however it should be possible to run outside of OSGi as well B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)

Coding

  • Internal packges must have internal in their name --Jan.koehnlein.itemis.de 08:56, 30 April 2008 (EDT)
  • Internal packages must have the internal right before the last segment of the plugin name: org.eclipse.xpand -> org.eclipse.internal.xpand B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)
  • Why not at the end of the package name? That makes them appear right next to their public counterparts on alphabetical sorting. (Arno)
  • If you add a (source-)folder make sure to update build.properties. --Jan.koehnlein.itemis.de 08:56, 30 April 2008 (EDT)
  • Generated code should always reside in separate folder clearly marked as generated, such as src-gen or emf-gen. I'd prefer to even generate code into spearate plug-ins, as some files, like MANIFEST.MF cannot be merged. --Jan.koehnlein.itemis.de 09:04, 30 April 2008 (EDT)
  • The name of Java packages in plug-in should start with the name of the plug-in. --Jan.koehnlein.itemis.de 09:16, 30 April 2008 (EDT)
  • Wherever possible, IDs for Eclipse extensions should take the same name as the corresponding class. --Peter.friese.itemis.de 09:46, 30 April 2008 (EDT) E.g. 
  class="org.openarchitectureware.core.properties.MetamodelContributorsPropertyAndPreferencePage"  
  id="org.openarchitectureware.core.properties.MetamodelContributorsPropertyPage"
  • All code has to be written with an OSGi environment in mind (classloading, reflection) B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)

Formating

  • In order to make for a homogeneous look of the source code, we use the built-in Eclipse formatter (with slight adoptions if neccessary) as far as possible. --Peter.friese.itemis.de 09:34, 30 April 2008 (EDT)
  • In order to have readable code, we avoid using the built-in Eclipse formatter and format code manually (Arno). Seriously, why do we need "homogeneous" look of the code? Why make a guideline for this!?
  • We use TABS instead of SPACES. --Peter.friese.itemis.de 09:34, 30 April 2008 (EDT)
  • We use SPACES instead of TABS so that code will look the same in all IDEs - the slightly reduced file size that is the only valid reason for using TABs has not been an issue for a long time. (Arno)
  • Curly braces will be places at the end of a line, not on a separate line. --Peter.friese.itemis.de 09:34, 30 April 2008 (EDT)
  • I do the same - but do we really need a formal guideline for this? (Arno)

Code Repository

  • Everything that is checked into the repository must compile and must not break the build. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • If you change code, make sure the unit tests are OK before you commit. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • Avoid checking in generated code. Find out how to automtically run the generator on the build server. --Jan.koehnlein.itemis.de 09:09, 30 April 2008 (EDT)

Plug-ins

  • We maintain one team project set in the CVS that is always up-to-date. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • We maintain an additional project set for anonymous access to the CVS (needed for non-committers). --Peter.friese.itemis.de 10:02, 30 April 2008 (EDT)
  • PSFs should be exported with working sets included. --Peter.friese.itemis.de 10:02, 30 April 2008 (EDT)
  • A Plug-in's ID must be the same as the project's name. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • A Plug-in's ID must be defined as a constant string in the plug-in class. --Dennis.huebner.itemis.de 09:49, 05 Mai 2008 (EDT)
  • Separate UI code and non-UI code in different plug-ins. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • If you add a plug-in, you must add it to the team project set. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • If you add a plug-in, add it to at least one feature. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • The name of a feature should always end with .feature. --Jan.koehnlein.itemis.de 08:57, 30 April 2008 (EDT)
  • The ID of a feature has to be equivalent with the 'main' plugin in the feature. So the feature name is the main plugin name + .feature
  • We need a way to communicate the addition of stuff to the project sets so everybody gets automatically notified and can check out the additional plug-ins. Suggestion: have Nick write a tool that scans .psf files for changes and notifies all developers of the respective module about this addition. --Peter.friese.itemis.de 09:52, 30 April 2008 (EDT)
  • We do NOT use Require-Bundle to import OSGi bundles, but instead use Import-Package. --Peter.friese.itemis.de 10:00, 30 April 2008 (EDT)
  • Imports always have to include a version range. It is not allowed to import any version of a package/bundle B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)

Logging and Tracing

Testing

  • Unit tests reside in a separate plug-in named <name of the plug-in to be tested>.tests --Jan.koehnlein.itemis.de 09:00, 30 April 2008 (EDT)
  • Unit tests may also reside in a fragment to a plugin named <name of the plug-in to be tested>.tests B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)
  • Unit tests should test a single feature only. Avoid tests that depend on a large number of features. Tests will be far easier to maintain. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • Never release before all tests are green on the build server. --Jan.koehnlein.itemis.de 08:51, 30 April 2008 (EDT)
  • If a test cannot be fixed, it is either obsolete or something is terribly wrong. Delete obsolete tests, fix all others. Never ignore failing tests. --Jan.koehnlein.itemis.de 09:14, 30 April 2008 (EDT)
  • All tests must also succeed on the build server. --Jan.koehnlein.itemis.de 09:14, 30 April 2008 (EDT)
  • As a result, all tests have to run in an eclipse / osgi environment. B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)

Build


Documentation

Additional Tools

  • GUI design: SWT Designer --Peter.friese.itemis.de 09:39, 30 April 2008 (EDT)
  • Bug hunting: FindBugs (triggered manually on the client, but run automatically on the build server) --Peter.friese.itemis.de 09:39, 30 April 2008 (EDT)
  • With what configuration will FindBugs be run on the build server? (Arno)
  • Bug hunting: CodePro AnalytiX? B.kolb.kolbware.de 10:30, 2 Mai 2008 (EDT)
  • Ensuring architectural constraints: SonarJ --Peter.friese.itemis.de 09:39, 30 April 2008 (EDT)
  • Profiling: YourKit --Peter.friese.itemis.de 09:39, 30 April 2008 (EDT)
Retrieved from "https://wiki.eclipse.org/index.php?title=OAW_Developer_Guidelines&oldid=96811"

Back to the top