Skip to main content

Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.

Jump to: navigation, search

Difference between revisions of "Nebula/Contributions"

(Add Documentation to the Wiki)
 
(100 intermediate revisions by 3 users not shown)
Line 1: Line 1:
= New Contributions =
+
Hi,  
Hi, welcome to the Eclipse Nebula project. We love new contributions. We aim to provide the Eclipse community with a rich set of rich UI compoments. So thank you for considering your contribution.
+
  
Before you decide to contribute your code to Eclipse, keep in mind that your code must follow the EPL, Eclipse's Public License. This means that committers and contributors need to follow some rules.
+
Welcome to the Eclipse Nebula project. We love new contributions. We provide the Eclipse community with a large set of rich UI components. So thank you for considering your contribution.
  
A good overview of what this entails and how this affects you [http://www.eclipse.org/legal/#Committers can be read here.]
+
__TOC__
  
== Introduce Yourself ==
+
=Contact=
If we don't know you, please take the time to introduce yourself to the Nebula mailing list. Be elaborate. Tell about your contributions, the bugs that you have filed, the patches that you committed. We need to know that you are a good Eclipse Citizen (Although this is not really necessary if you have a killer UI component to contribute ;).
+
* [https://dev.eclipse.org/mailman/listinfo/nebula-dev Mailing list]
 +
* [https://www.eclipse.org/forums/index.php/f/64/ Newsgroup/Forum]
  
You can subscribe to the mailing list by writing a mail to the mailing list administrator. How this is done is all explained [https://dev.eclipse.org/mailman/listinfo/nebula-dev on this page]. Tell us what your plans are and what your UI component does. Then wait for the discussion. If nothing happens for a while: be patient and persistent. We '''''love''''' new contributions.
+
=New Users=
 +
* [[Nebula/Contributions/Setup IDE|Setup Your IDE]]
  
== Code Quality and Citizenship ==
+
= Pull Requests =
Once part of the Nebula project, your code is visible to thousands of developers. Make sure that you provide quality code. Also make sure that your widget is stable even if your API is not. The work that you provide represents the complete Nebula community.  Ask on the list if you are not sure. Take a look at [http://www.eclipse.org/nebula/author_tips.php the widget author tips]. The user interface is a very important part of any application.  
+
We use [https://help.github.com/articles/about-pull-requests/ GitHub Pull Requests] to accept all your patches on the [https://github.com/eclipse/nebula Nebula GitHub repository].  
  
Once you are in the project, take care of your bug reports and make sure that they are followed up. We require that you do not only take care of your own component but also look after the greater Nebula together with the other active committers.
+
See GitHub's extensive documentation on working with Pull Requests. Start with the [https://help.github.com/articles/github-flow/ GitHub flow overview] and then continue with the rest of the [https://help.github.com/categories/collaborating-with-issues-and-pull-requests/ documentation].
  
== File a bug to request your contribution ==
+
== File a gitHub Issue==
You will be instructed by one of the project leads to file a bug against Nebula core in bugzilla. Before you can do that, you need to get an Eclipse account. This can be done [https://bugs.eclipse.org/bugs/ on the Bugzilla landing page]. Once the account has been created you need to file a bug against Nebula Core.  
+
For administration purposes [https://github.com/eclipse/nebula/issues we require a GitHub issue] for every pull request.
  
Here are some example bugs of previous contributions:
+
== Reference the issue in the pull request ==
 +
Reference the issue number in the Pull Request subject (e.g., "Add loading debug to XViewer #351")
  
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=328836
+
== Patches with a signed ECA ==
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=365948
+
To provide patches to Nebula, sign the [https://www.eclipse.org/legal/ECA.php ECA] (click on the ECA Form link in the bold paragraph, [https://accounts.eclipse.org/user/register creating a new account] if you do not have one already), fork [https://github.com/eclipse/nebula Nebula] on GitHub and submit a Pull Request.
  
You need to include the source code and additional resources like images and stuff like that (one or more plug-in projects) as an attachement. Only the code that you own and have the copyright. Each source member needs to have the standard EPL header like you see in every Eclipse source. Do not include any third party code. Do not include any zip files in the projects. Just your sources and other resources. You can include somoe additional information like links to the working product or links to screenshots.
+
* [[Nebula/Contributions/Setup IDE|Setup Your IDE]]
 +
* [https://wiki.eclipse.org/GitHub All you need to know about GitHub use at Eclipse, and more.]
  
In addition, You need to declare that:
+
Please always use a valid issue description and number and use the following commit message:
  
* I authored 100% of the content
+
Add loading debug to XViewer #351
* I have the right to contribute the content to Eclipse
+
<empty line>
* I contribute the content under the EPL
+
A good description of the changes you made.
  
Once you are ready, [https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Nebula&component=Core?summary=Contribution%20%of file the bug against Nebula/Core].
+
Add the new commits to the branch you used for the pull request to update an existing commit.
  
== Provide Legal Information ==
+
== Patches without a signed ECA ==
If your code is to be distributed from Eclipse, we need to you comply to some legal rules. One of the rules is the inclusion of copyright notices in source code and legal documents in features and plug-ins.  
+
We cannot accept patches, in any form, without a signed [https://www.eclipse.org/legal/ECA.php ECA].
  
Information about this is described in [http://www.eclipse.org/legal/guidetolegaldoc.php A Guide to the Legal Documentation for Eclipse-Based Content] which [http://www.eclipse.org/legal/#Committers is linked from here.]
+
= Building =
 +
You can find the Jenkins jobs here, which build the pull requests.
  
== We will assess your contribution ==
+
* https://ci.eclipse.org/nebula/job/nebula.stable.github/
We will take a look at your code to assess the quality. If we have problems with it we will let you know on the bug. We will also do a preliminary check on any [[IP_Stuff|IP (Intelectual Property) issues]]. After this is done, one of the project leads will file a new bug in a separate Bugzilla system known as IPZilla. This bug is called a [[Development Resources/Contribution Questionnaire|CQ (Contribution Questionnaire)]].
+
* https://ci.eclipse.org/nebula/job/nebula.incubation.github/
  
Here an automatic scanning of the source will take place. It will be examined on foul words, religious statements, terroristic information and all that. You will also need to declare that you have the rights to the code.
 
  
One of the [http://www.eclipse.org/eclipse/eclipse-charter.php Eclipse PMC members will do some magic and authorize] the CQ. After this has been done, we have to wait on the Eclipse legal team to do a triage on the code and give their final OK.
+
All members of the [https://github.com/orgs/eclipse/people GitHub Eclipse organization] should have their PRs built automatically as the whole organization is on the whitelist. All other PRs need to be approved before they are built for the first time. To approve a PR, you have to be an admin and say:
  
== Start a Committer vote for you ==
+
* "ok to test" to accept this pull request for testing
Roughly during the same time, you will be voted into the Nebula committer community. This is a process of the community and is in general a formality but you cannot have any votes against you. Once you are voted in, you will be provided with an Eclipse committer ID by the [[Webmaster_FAQ|Eclipse Webmasters]].
+
* "test this please" for a one-time test run
 +
* "add to whitelist" to add the author to the whitelist
  
== Create a Contribution to the Example View ==
 
Nebula contains an overall Example View that provides an extension point. With this extension point you can contribute a Tab to the view that shows all the details of your widget.
 
  
All Nebula Widgets are required to contribute to this extension point in a separate bundle.
+
If the build fails for various reasons, you can rebuild.
  
== Organize your Code ==
 
You will get your own personal slot in the Nebula git repository. we are forked on github and your [https://github.com/eclipse/nebula/tree/master/widgets component will be included into this folder]. The official repository is hosted at Eclipse. If you have a really big project, it is also possible to become a sub project of the greater Nebula. You will then operate semi-independent from Nebula and take care of your own builds and 
 
repository.
 
  
If you are not your own sub project then you will first start in the Nebula incubation area. You will need to provide several components to become part of the Nebula code.
+
* "retest this please" to start a new build
  
Lets take a look at the structure of the Oscilloscope widget.
+
See the full documentation for the [https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin GitHub Pull Request plug-in for Jenkins].
  
* org.eclipse.nebula.widgets.'''oscilloscope'''
+
== Building locally ==
*:This is the main code of this widget. It is included in one project but your UI component can span more than one project. Please follow the namespace and discuss on the mailing list what the best name of the component can be.
+
To build locally [[Nebula/Builds|refer to the builds page]]
* org.eclipse.nebula.widgets.'''oscilloscope.example'''
+
*: This is the contribution to the Example view. Every component is required to contribute to the example view. Here you can showcase your widget. Make it as fancy as possible.
+
* org.eclipse.nebula.widgets.'''oscilloscope.feature'''
+
*: The feature project that will contain only your UI component. Please take a look at the contents of other features for inspiration. Make sure to provide the correct naming and descriptions in the feature and follow the same pattern as the other features.
+
* org.eclipse.nebula.widgets.'''oscilloscope.snippets'''
+
*: This contains the snippets for your code. Snippets contain short code examples on how to use your widget. This is mandatory. See other snippet projects for some inspiration.
+
* org.eclipse.nebula.widgets.'''oscilloscope.tests'''
+
*: This contains the unit tests for your component. Obviously this is also mandatory. Please provide a code coverage of at least 80%.
+
  
== Checkin your code ==
+
= New Committers=
With your committer account you can check-in your code into git. You will need the ssh link [http://git.eclipse.org/c/nebula/org.eclipse.nebula.git as provided on this page]Once your code is checked in, we have to add you to the build. If you are comfortable with it, see the releng section of the repository and add your component, otherwise drop a line on the list and we are happy to help you with it.
+
Before you decide to contribute your code to Eclipse, keep in mind that your code must follow the EPL, Eclipse's Public LicenseThis means that committers and contributors need to follow some rules.
  
== Provide Build information ==
+
A good overview of what this entails and how this affects you [http://www.eclipse.org/legal/#Committers can be read here.]
We use tycho to build the Nebula after every commit. Please take a look at the pom.xml files in the other widgets and apply a copy and paste to your projects. Once you think your product is ready for the main stage, give the list a signal. We will then include your widget in the incubation build. It needs to stay there until it is API stable. If you break the build you break everything. So be careful with what you commit, take a keen eye on the build and fix any build errors as soon as possible.
+
  
Here are the links to our current build jobs:
+
There are several ways you can contribute.
  
https://hudson.eclipse.org/hudson/job/nebula.nebula/
+
# A new project inside Nebula
https://hudson.eclipse.org/hudson/job/nebula.incubation/
+
# New widgets in the Nebula Release project (production-ready).
 +
# New widgets in the Nebula Incubation project.
 +
# Maintain existing widgets
  
Once you are a committer you have access to the build configuration.
+
If you choose the first option, please contact the Nebula lead through the [https://dev.eclipse.org/mailman/listinfo/nebula-dev mailing list] and make your intentions clear. [[Development Resources/HOWTO/Starting A New Project|Then continue to read on this page.]]
  
== Add Component to the Website ==
+
==New Widgets==
Once you are a committer, you are able to checkout the website. If you checkin, the new code is published within 5 minutes. How to check out the Nebula website and make changes [[IT_Infrastructure_Doc|is explained here]]. If you have questions please ask them on the list.  
+
The new widget process is described here:
 +
 
 +
<big>[[Nebula/Contributions/New Widgets|Nebula/Contributions/New Widgets]]</big>
 +
 
 +
== Introduce Yourself ==
 +
If we don't know you, please take the time to introduce yourself to the Nebula mailing list. Be elaborate. Things that you talk about could be your contributions, the bugs that you have filed, the patches that you committed, your experience in UI development, etcetera. We need to know that you are the kind of person that we want to have on board. If you are not comfortable with this, it could also be enough to point to the code that you want to contribute and tell us how this could be useful to the greater Nebula community.
 +
 
 +
You can subscribe to the mailing list [https://dev.eclipse.org/mailman/listinfo/nebula-dev on this page], you need an Eclipse account first, [https://accounts.eclipse.org/user/register create one here]. Let us know what your plans are and what your UI component does. Then wait for the discussion. If nothing happens immediately: be patient and persistent. We '''''love''''' new contributions.
 +
 
 +
== Code Quality and Citizenship ==
 +
Once part of the Nebula project, your code is visible to thousands of developers. Make sure that you provide quality code. Also, make sure that your widget is stable even if your API is not. The work that you provide represents the complete Nebula community.  Ask on the list if you are not sure. Take a look at [http://www.eclipse.org/nebula/author_tips.php the widget author tips]. The user interface is an essential part of any application.
 +
 
 +
Once you are in the project, take care of your bug reports and make sure that they are followed up. We require that you do not only take care of your own component and look after the greater Nebula together with the other active committers.
  
 
== Add Documentation to the Wiki ==
 
== Add Documentation to the Wiki ==
 
Your component needs to be documented [[Nebula|on the main Nebula wiki page]].
 
Your component needs to be documented [[Nebula|on the main Nebula wiki page]].
  
[Category:Nebula]
+
== Watch the repository ==
 +
It is required that all committers watch the repository to stay up to date with what is going on in our community.
 +
 
 +
= Become a committer=
 +
If you do not provide a new widget contribution but still want to become a Nebula committer, then the following applies:
 +
 
 +
Based on your role in the Eclipse community, you can become a full committer in the Nebula project. For this, you have to show commitment to the project by maintaining your code and play an active role in the Nebula community as a whole. Once this is established, you are invited by one of the current committers of the Nebula project to become a committer. If you feel that you are ready for full committer status, but you are not yet invited, you can solicit for the position yourself either through the list or by personal mail to the project lead.
 +
 
 +
The voting process is a formality, but you cannot have any votes against you (-1). Once you are voted in (three or more +1), you will be provided with an Eclipse committer ID by the [[Webmaster_FAQ|Eclipse Webmasters]].
 +
 
 +
[[Category:Nebula|Contributions]]

Latest revision as of 12:09, 4 March 2022

Hi,

Welcome to the Eclipse Nebula project. We love new contributions. We provide the Eclipse community with a large set of rich UI components. So thank you for considering your contribution.

Contact

New Users

Pull Requests

We use GitHub Pull Requests to accept all your patches on the Nebula GitHub repository.

See GitHub's extensive documentation on working with Pull Requests. Start with the GitHub flow overview and then continue with the rest of the documentation.

File a gitHub Issue

For administration purposes we require a GitHub issue for every pull request.

Reference the issue in the pull request

Reference the issue number in the Pull Request subject (e.g., "Add loading debug to XViewer #351")

Patches with a signed ECA

To provide patches to Nebula, sign the ECA (click on the ECA Form link in the bold paragraph, creating a new account if you do not have one already), fork Nebula on GitHub and submit a Pull Request.

Please always use a valid issue description and number and use the following commit message:

Add loading debug to XViewer #351 
<empty line>
A good description of the changes you made.

Add the new commits to the branch you used for the pull request to update an existing commit.

Patches without a signed ECA

We cannot accept patches, in any form, without a signed ECA.

Building

You can find the Jenkins jobs here, which build the pull requests.


All members of the GitHub Eclipse organization should have their PRs built automatically as the whole organization is on the whitelist. All other PRs need to be approved before they are built for the first time. To approve a PR, you have to be an admin and say:

  • "ok to test" to accept this pull request for testing
  • "test this please" for a one-time test run
  • "add to whitelist" to add the author to the whitelist


If the build fails for various reasons, you can rebuild.


  • "retest this please" to start a new build

See the full documentation for the GitHub Pull Request plug-in for Jenkins.

Building locally

To build locally refer to the builds page

New Committers

Before you decide to contribute your code to Eclipse, keep in mind that your code must follow the EPL, Eclipse's Public License. This means that committers and contributors need to follow some rules.

A good overview of what this entails and how this affects you can be read here.

There are several ways you can contribute.

  1. A new project inside Nebula
  2. New widgets in the Nebula Release project (production-ready).
  3. New widgets in the Nebula Incubation project.
  4. Maintain existing widgets

If you choose the first option, please contact the Nebula lead through the mailing list and make your intentions clear. Then continue to read on this page.

New Widgets

The new widget process is described here:

Nebula/Contributions/New Widgets

Introduce Yourself

If we don't know you, please take the time to introduce yourself to the Nebula mailing list. Be elaborate. Things that you talk about could be your contributions, the bugs that you have filed, the patches that you committed, your experience in UI development, etcetera. We need to know that you are the kind of person that we want to have on board. If you are not comfortable with this, it could also be enough to point to the code that you want to contribute and tell us how this could be useful to the greater Nebula community.

You can subscribe to the mailing list on this page, you need an Eclipse account first, create one here. Let us know what your plans are and what your UI component does. Then wait for the discussion. If nothing happens immediately: be patient and persistent. We love new contributions.

Code Quality and Citizenship

Once part of the Nebula project, your code is visible to thousands of developers. Make sure that you provide quality code. Also, make sure that your widget is stable even if your API is not. The work that you provide represents the complete Nebula community. Ask on the list if you are not sure. Take a look at the widget author tips. The user interface is an essential part of any application.

Once you are in the project, take care of your bug reports and make sure that they are followed up. We require that you do not only take care of your own component and look after the greater Nebula together with the other active committers.

Add Documentation to the Wiki

Your component needs to be documented on the main Nebula wiki page.

Watch the repository

It is required that all committers watch the repository to stay up to date with what is going on in our community.

Become a committer

If you do not provide a new widget contribution but still want to become a Nebula committer, then the following applies:

Based on your role in the Eclipse community, you can become a full committer in the Nebula project. For this, you have to show commitment to the project by maintaining your code and play an active role in the Nebula community as a whole. Once this is established, you are invited by one of the current committers of the Nebula project to become a committer. If you feel that you are ready for full committer status, but you are not yet invited, you can solicit for the position yourself either through the list or by personal mail to the project lead.

The voting process is a formality, but you cannot have any votes against you (-1). Once you are voted in (three or more +1), you will be provided with an Eclipse committer ID by the Eclipse Webmasters.

Back to the top