Skip to main content
Jump to: navigation, search

Difference between revisions of "JSDT/Development"

(Reviewing a patch)
Line 38: Line 38:
==== Pushing a new patch for review ====
==== Pushing a new patch for review ====
You can use [[Gerrit]] (mandatory reading, important to set up hooks, SSH keys, CLA & other) to push Git commits on JSDT repositories. The repo URL for JSDT@Gerrit is <tt>ssh://</tt>. Once logged into Gerrit, you can see more details about the URL at .
You can use [[Gerrit]] (mandatory reading, important to set up hooks, SSH keys, CLA & other) to push Git commits on JSDT repositories. The repo URL for JSDT@Gerrit is <tt>ssh://</tt>. Once logged into Gerrit, you can see more details about the URL at .
Assuming you named this repo ''gerrit'', you can push a commit to one of this repository with
Assuming you named this repo ''gerrit'', you can push a commit to one of this repository with

Revision as of 10:57, 13 June 2014

Mailing ListForumsIRCmattermost
OpenHelp WantedBug Day
Browse Source

As of WTP 3.0, JSDT is part of the Web Tools Platform.

Contributing to JSDT

The JSDT is driven by a very small development group with limited resources. ANY serious developers or contributors will be enthusiastically welcomed. For more information on how to become a Committer, check the standard Eclipse process (see New Committer Election). For more information about contributing to JSDT in general, or for questions about its internals, contact wtp-dev.

JSDT Functional Testing

Testing Scenarios

Reporting Bugs

Report bugs through Eclipse Bugzilla under WebTools catagory, JSDT component.

Here is a list of open JSDT bugs. We're working through them as fast as we can!

You can receive notifications of incoming bugs by monitoring account in

JSDT Sources

Git Repository: webtools.jsdt.git

Detailed repository contents you can find at this page:

These plug-ins have no dependencies other than the Eclipse base (nor do they depend on anything else in WTP). Using these plug-ins, a standalone JavaScript Project can be created and used:

  • bundles/org.eclipse.wst.jsdt.core
  • org.eclipse.wst.jsdt.manipulation
  • org.eclipse.wst.jsdt.ui

The Feature project for these is:

  • features/org.eclipse.wst.jsdt.feature

Building and testing JSDT locally

Simply run mvn clean verify -Pbuild-individual-bundles -DskipTests=false. This command will run the Unit-tests. After the build, you can install your JSDT snapshot in an Eclipse IDE or other RCP application using the p2 repository in location site/target/repository

Gerrit Reviews

Pushing a new patch for review

You can use Gerrit (mandatory reading, important to set up hooks, SSH keys, CLA & other) to push Git commits on JSDT repositories. The repo URL for JSDT@Gerrit is ssh:// Once logged into Gerrit, you can see more details about the URL at .

Assuming you named this repo gerrit, you can push a commit to one of this repository with

$ git push gerrit HEAD:refs/for/master

This will give you the URL of the Gerrit review where you can interact with project committers to get your commit merged.

In case you need to push another version of the patch, don't forget to copy the Change-Id from the Gerrit review if you didn't set up the git hook. Providing another version of the patch doesn't require a new commit, simply amend the one you already pushed, and push it again:

$ git log -1 #Shows the commit. Message should contain Sign-Off-By and Change-Id
$ git add file/to/change
$ git commit --amend # add --signoff if Sign-Off-By is missing, and copy Change-Id from Gerrit review if missing
$ git push gerrit HEAD:refs/for/master # will create another version of the patch, on the same review.

Reviewing a patch

Incoming patch automatically triggers a build and will receive an automated vote according to whether patch breaks the build/tests or not. The CI job providing this vote is

  • Anytime Hudson votes with -1, it generally means that something is wrong with the patch: it breaks build or make a test failing, so the patch shouldn't be merged. The build log should be inspected by submitter and reviewers to understand the cause of the bug and submit (or assist in submitting) a better patch.
  • Hudson voting +1 means that the test didn't introduce any regression visible by build or automated tests.

Anyone is free to add comments and vote on a review. Committers have the final power to decide whether or not a patch can be merged.

List reviews and be notified

You can see the list of open Gerrit reviews at,n,z .

Regular contributors and committers should really subscribe to notifications of proposed patches. You can set up notifications for proposed incoming changes at

Static analysis with SonarQube

JSDT uses SonarQube to get reports about static analysis. Those can show potential bugs, performance traps, or just bad practices. Here is the status of JSDT on these topics: . Any help to clean up warnings is welcome!


HTML an JSP editors

JSDT provides JavaScript support for the WTP HTML and JSP editors in the WTP Source Editing project Git repositories. GitHub

The following plug-in projects provide JSDT integration with WTP's HTML and JSP editors:

  • webtools.sourceediting.git/bundles/org.eclipse.wst.jsdt.web.core
  • webtools.sourceediting.git/bundles/plugins/org.eclipse.wst.jsdt.web.ui
  • webtools.sourceediting.git/bundles/plugins/ - contains JSP-specific functionality
  • webtools.sourceediting.git/bundles/plugins/ - contains bindings for Mozilla FireFox, current as of FF 2.0.x (deprecated)
  • webtools.sourceediting.git/bundles/plugins/ - contains bindings for Microsoft Internet explorer (deprecated)

JSDT tests

The following are the JUnits test plug-ins for JSDT:

  • tests/org.eclipse.wst.jsdt.core.tests.compiler - (test suite is org.eclipse.wst.jsdt.core.tests.compiler.JSDTTestAll)
  • tests/org.eclipse.wst.jsdt.core.tests.model - (test suite is org.eclipse.wst.jsdt.core.tests.model.AllJavaModelTests)

These test plug-ins are new to WTP 3.1 and above:

  • webtools.sourceediting.tests.git/tests/org.eclipse.wst.jsdt.web.core.tests - (test suite is org.eclipse.wst.jsdt.web.core.tests.translation.AllWebCoreTests)
  • webtools.sourceediting.tests.git/tests/org.eclipse.wst.jsdt.web.ui.tests - (test suite is org.eclipse.wst.jsdt.web.ui.tests.AllWebUITests)

These test plug-ins are new to WTP 3.2 and above:

  • webtools.jsdt.tests.git/tests/org.eclipse.wst.jsdt.ui.tests - (test suite is org.eclipse.wst.jsdt.ui.tests.JSDTUITests)

JSDT packages


The JSDT core plugin (org.eclipse.wst.jsdt.core) provides the core JavaScript modeling.

Core plugin packages
package function
org.eclipse.wst.jsdt.core public apis for the module
org.eclipse.wst.jsdt.core.ast The public apis for the read-only AST used by inference engines
org.eclipse.wst.jsdt.core.compiler the public apis for the validator
org.eclipse.wst.jsdt.core.compiler.libraries libraries which define the javascript language apis and the browser DOM apis
org.eclipse.wst.jsdt.core.dom Modifiable JavaScript model DOM
org.eclipse.wst.jsdt.core.dom.rewrite support for updating the dom
org.eclipse.wst.jsdt.core.eval support for evaluating code fragments
org.eclipse.wst.jsdt.core.formatter public apis for javascript formatting
org.eclipse.wst.jsdt.core.infer support for inferencing and inferencing extensions public apis for search
org.eclipse.wst.jsdt.core.util public utility apis
org.eclipse.wst.jsdt.internal.codeassist support for code assist and selection
org.eclipse.wst.jsdt.internal.codeassist.complete support for code assist
org.eclipse.wst.jsdt.internal.codeassist.impl support for code assist support for code selection
org.eclipse.wst.jsdt.internal.compiler validation code
org.eclipse.wst.jsdt.internal.compiler.ast internal javascript AST (Abstract Syntax Tree)
org.eclipse.wst.jsdt.internal.compiler.batch support for batch validation
org.eclipse.wst.jsdt.internal.compiler.classfmt  ??
org.eclipse.wst.jsdt.internal.compiler.env  ??
org.eclipse.wst.jsdt.internal.compiler.flow support for analyzing code flow for unused vars, etc
org.eclipse.wst.jsdt.internal.compiler.impl implementation of public apis
org.eclipse.wst.jsdt.internal.compiler.lookup support for resolving var/function references
org.eclipse.wst.jsdt.internal.compiler.parser the parser
org.eclipse.wst.jsdt.internal.compiler.parser.diagnose the diagnose parser used when there are syntax errors
org.eclipse.wst.jsdt.internal.compiler.problem support for problem messages
org.eclipse.wst.jsdt.internal.compiler.util parser/validator utilities
org.eclipse.wst.jsdt.internal.core implementation of public apis
org.eclipse.wst.jsdt.internal.core.builder implementation of eclipse builder extension
org.eclipse.wst.jsdt.internal.core.dom.rewrite support for updating code on DOM changes
org.eclipse.wst.jsdt.internal.core.hierarchy support for generating class hierarchy
org.eclipse.wst.jsdt.internal.core.index support for indexing the model, used by search
org.eclipse.wst.jsdt.internal.core.interpret javascript interpreter - under development , currently not used
org.eclipse.wst.jsdt.internal.core.interpret.builtin implementation of javascript language functions used by interpreter searching functions indexing of javascript functions to determine if possible search match is exact match search
org.eclipse.wst.jsdt.internal.core.util internal utilities
org.eclipse.wst.jsdt.internal.formatter formatter implementation
org.eclipse.wst.jsdt.internal.formatter.align formatter implementation
org.eclipse.wst.jsdt.internal.formatter.comment comment formatter implementation
org.eclipse.wst.jsdt.internal.oaametadata support for OpenAjax metadata
org.eclipse.wst.jsdt.launching misc utilities
org.eclipse.wst.jsdt.libraries Library support


User interface code

Core plugin packages
package function
org.eclipse.wst.jsdt.internal.corext refactoring support
org.eclipse.wst.jsdt.internal.corext.buildpath support for include path editing
org.eclipse.wst.jsdt.internal.corext.callhierarchy support for call hierarchy
org.eclipse.wst.jsdt.internal.corext.codemanipulation support for code refactoring
org.eclipse.wst.jsdt.internal.corext.dom.fragments support for manipulating dom fragments
org.eclipse.wst.jsdt.internal.corext.fix support for quick fix
org.eclipse.wst.jsdt.internal.corext.javadoc support for jsdoc editing
org.eclipse.wst.jsdt.internal.corext.refactoring support for refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.base support for refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.changes refactoring change classes
org.eclipse.wst.jsdt.internal.corext.refactoring.code refactoring of code segments
org.eclipse.wst.jsdt.internal.corext.refactoring.code.flow support for refactoring of code segments
org.eclipse.wst.jsdt.internal.corext.refactoring.delegates support for "create delegates" action
org.eclipse.wst.jsdt.internal.corext.refactoring.generics currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.nls currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.rename rename refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.reorg copy/move refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.scripting support for scripiting of refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.sef encapsulate field refactoring
org.eclipse.wst.jsdt.internal.corext.refactoring.typeconstraints currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.typeconstraints.types currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.typeconstraints.typesets currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.typeconstraints2 currently unused
org.eclipse.wst.jsdt.internal.corext.refactoring.util refactoring utilities support for templates
org.eclipse.wst.jsdt.internal.ui.actions implementation of actions
org.eclipse.wst.jsdt.internal.ui.browsing currently unused - support for browse perspective
org.eclipse.wst.jsdt.internal.ui.callhierarchy ui for call hierarchy
org.eclipse.wst.jsdt.internal.ui.commands compare ui
org.eclipse.wst.jsdt.internal.ui.dialogs various diaglogs
org.eclipse.wst.jsdt.internal.ui.dnd drag/drop support
org.eclipse.wst.jsdt.internal.ui.filters implementation of view filters
org.eclipse.wst.jsdt.internal.ui.fix automatic cleanup functions
org.eclipse.wst.jsdt.internal.ui.infoviews various views
org.eclipse.wst.jsdt.internal.ui.javadocexport export of js doc
org.eclipse.wst.jsdt.internal.ui.javaeditor javascirpt editor implementation
org.eclipse.wst.jsdt.internal.ui.javaeditor.selectionactions change selection actions
org.eclipse.wst.jsdt.internal.ui.navigator implementation of navigator
org.eclipse.wst.jsdt.internal.ui.packageview implementation of script explorer
org.eclipse.wst.jsdt.internal.ui.preferences preferences ui
org.eclipse.wst.jsdt.internal.ui.preferences.cleanup ui for cleanup preferences
org.eclipse.wst.jsdt.internal.ui.preferences.formatter ui for formatter preferences
org.eclipse.wst.jsdt.internal.ui.refactoring ui for refactoring preferences
org.eclipse.wst.jsdt.internal.ui.refactoring.actions actions for refactoring
org.eclipse.wst.jsdt.internal.ui.refactoring.nls current unused
org.eclipse.wst.jsdt.internal.ui.refactoring.reorg move/copy/delete
org.eclipse.wst.jsdt.internal.ui.refactoring.sef search ui
org.eclipse.wst.jsdt.internal.ui.text javascript source editing utilites
org.eclipse.wst.jsdt.internal.ui.text.comment comment editing
org.eclipse.wst.jsdt.internal.ui.text.correction quick fix implementation
org.eclipse.wst.jsdt.internal.ui.text.folding folding implementation
org.eclipse.wst.jsdt.internal.ui.text.html editing of html inside jsdoc content assist implementation hover help
org.eclipse.wst.jsdt.internal.ui.text.javadoc jsdoc editing
org.eclipse.wst.jsdt.internal.ui.text.spelling spell checking
org.eclipse.wst.jsdt.internal.ui.text.template.contentassist content assist templates
org.eclipse.wst.jsdt.internal.ui.text.template.preferences template editing
org.eclipse.wst.jsdt.internal.ui.typehierarchy type hierarchy ui
org.eclipse.wst.jsdt.internal.ui.util utilities
org.eclipse.wst.jsdt.internal.ui.viewsupport view utilities
org.eclipse.wst.jsdt.internal.ui.wizards wizards
org.eclipse.wst.jsdt.internal.ui.wizards.buildpaths include path editing

Generating the parser

Follow the instructions at for generating the parser. The parser grammer file is located in cvs at sourceediting/plugins/org.eclipse.wst.jsdt.core/grammer/js.g

Back to the top