Jump to: navigation, search

Difference between revisions of "GMF Dev Call 20070410"

(Notes)
m (Notes)
Line 5: Line 5:
 
===Notes===
 
===Notes===
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=159479 159479] - Artem can provide patch if needed.  Tooling doesn't like using annotations as the approach.  Mohammed has task to look into this (notation metamodel extension) - will add to cc on this bug?
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=159479 159479] - Artem can provide patch if needed.  Tooling doesn't like using annotations as the approach.  Mohammed has task to look into this (notation metamodel extension) - will add to cc on this bug?
 +
 +
'''Update''': Artem agreed to identify more examples of how the runtime does not inherently support the notion of a view referencing other views, while Mohammed agreed to add an additional style.  Details will follow in the bug comments.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=164491 164491] - Tooling generates code now, seems reasonable to add to runtime.  A patch was provided, and will be reviewed (assigned to Mohammed).
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=164491 164491] - Tooling generates code now, seems reasonable to add to runtime.  A patch was provided, and will be reviewed (assigned to Mohammed).
  
 
Note: several canonical issues already assigned to Mohammed - have a follow up 2nd week in April when Mohammed back from vacation
 
Note: several canonical issues already assigned to Mohammed - have a follow up 2nd week in April when Mohammed back from vacation
 +
 +
'''Update''': Mohammed will review/commit patch provided.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=146774 146774] - should be handled by EMF? ;-)  For now, have an approach for plugin.xml, but need ideas for manifest.  Linda suggests just not overwriting, as EMF does (not ideal).  Artem suggests utilizing VCS features to merge changes, or direct generation output to file next to manifest.mf if it exists.  All feel this is not critical.
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=146774 146774] - should be handled by EMF? ;-)  For now, have an approach for plugin.xml, but need ideas for manifest.  Linda suggests just not overwriting, as EMF does (not ideal).  Artem suggests utilizing VCS features to merge changes, or direct generation output to file next to manifest.mf if it exists.  All feel this is not critical.
Line 19: Line 23:
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=159289 159289] - look at proposed approach for [https://bugs.eclipse.org/bugs/show_bug.cgi?id=152445 152445].  There is a way to do it, but same issue as above - shouldn't need to remove items.
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=159289 159289] - look at proposed approach for [https://bugs.eclipse.org/bugs/show_bug.cgi?id=152445 152445].  There is a way to do it, but same issue as above - shouldn't need to remove items.
 +
 +
'''Update''': A question of how to deal with clients adding actions which would result with duplication.  Artem suggested this is no different than with any contribution a client may make.  More thought required on this one.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=150257 150257] - Mohammed will look at when gets back.
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=150257 150257] - Mohammed will look at when gets back.
 +
 +
'''Update''': Alex will look into suggested method.  Bugzilla will be updated based on suggestions/findings.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=150408 150408] - Mohammed
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=150408 150408] - Mohammed
 +
 +
'''Update''': Mohammed to look into. Alex mentioned potential new wrinkle with links to links feature.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=154748 154748] - Mohammed - an ugly workaround present, part is platform issue
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=154748 154748] - Mohammed - an ugly workaround present, part is platform issue
 +
 +
'''Update''': Mohammed will review/commit patch provided.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=138442 138442] - Changes to gmfmap needed, need to be investigated further.. not easily achieved.  Can't be done by API freeze.  Doesn't seem to be a popular usecase for all but complex domain modelers (e.g. UML).  Now, custom templates can be used to workaround.  Better documentation provided to workaround would be good.
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=138442 138442] - Changes to gmfmap needed, need to be investigated further.. not easily achieved.  Can't be done by API freeze.  Doesn't seem to be a popular usecase for all but complex domain modelers (e.g. UML).  Now, custom templates can be used to workaround.  Better documentation provided to workaround would be good.
Line 33: Line 45:
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=133505 133505] - Mohammed (canonical)
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=133505 133505] - Mohammed (canonical)
 +
 +
'''Update''': Discussion on possible solution to take place in bugzilla.
  
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=129533 129533] - Not planned for this release.  Artem to add detail re: use of unique ids, as he recalls it was part of the original conversation.
 
[https://bugs.eclipse.org/bugs/show_bug.cgi?id=129533 129533] - Not planned for this release.  Artem to add detail re: use of unique ids, as he recalls it was part of the original conversation.
Line 51: Line 65:
  
 
'''WONTFIX''' [https://bugs.eclipse.org/bugs/show_bug.cgi?id=174498 174498] - .trace will work for now, not sure why it's still open?  Linda realized here why trace functionality is "experimental" :)  Can close.
 
'''WONTFIX''' [https://bugs.eclipse.org/bugs/show_bug.cgi?id=174498 174498] - .trace will work for now, not sure why it's still open?  Linda realized here why trace functionality is "experimental" :)  Can close.
 +
 +
'''New Item''': Why does generated code not use Shape style?  Artem asked for a bugzilla to be opened to look into this further.

Revision as of 12:58, 10 April 2007

The following issues were discussed during our second GMF Dev Call. This was a follow up call from the one held March 21st:

Attendees

Notes

159479 - Artem can provide patch if needed. Tooling doesn't like using annotations as the approach. Mohammed has task to look into this (notation metamodel extension) - will add to cc on this bug?

Update: Artem agreed to identify more examples of how the runtime does not inherently support the notion of a view referencing other views, while Mohammed agreed to add an additional style. Details will follow in the bug comments.

164491 - Tooling generates code now, seems reasonable to add to runtime. A patch was provided, and will be reviewed (assigned to Mohammed).

Note: several canonical issues already assigned to Mohammed - have a follow up 2nd week in April when Mohammed back from vacation

Update: Mohammed will review/commit patch provided.

146774 - should be handled by EMF? ;-) For now, have an approach for plugin.xml, but need ideas for manifest. Linda suggests just not overwriting, as EMF does (not ideal). Artem suggests utilizing VCS features to merge changes, or direct generation output to file next to manifest.mf if it exists. All feel this is not critical.

RESOLVED 174496 - Artem will fix by M6, or shortly afterwards. A more sophisticated transformation approach required to fix properly.

152445 - This request has come up before. Option: do not provide it in the runtime at all? Now, tooling has to remove it, which seems odd as it was disabled to begin with. Next release.. create a clean diagram with just add on functionality, rather than remove functionality added by default. Move these default contributions to another plugin? Take out *.diagram.ui.providers plug-in to remove all actions, then look into adding back what's there?

RESOLVED 157188 - Introduced with another bug fix (112998). Will fix.

159289 - look at proposed approach for 152445. There is a way to do it, but same issue as above - shouldn't need to remove items.

Update: A question of how to deal with clients adding actions which would result with duplication. Artem suggested this is no different than with any contribution a client may make. More thought required on this one.

150257 - Mohammed will look at when gets back.

Update: Alex will look into suggested method. Bugzilla will be updated based on suggestions/findings.

150408 - Mohammed

Update: Mohammed to look into. Alex mentioned potential new wrinkle with links to links feature.

154748 - Mohammed - an ugly workaround present, part is platform issue

Update: Mohammed will review/commit patch provided.

138442 - Changes to gmfmap needed, need to be investigated further.. not easily achieved. Can't be done by API freeze. Doesn't seem to be a popular usecase for all but complex domain modelers (e.g. UML). Now, custom templates can be used to workaround. Better documentation provided to workaround would be good.

Dmitry - generator should provide todo methods for user in these cases (that, with documentation would be best approach for now).

Should be assigned to someone other than Radek?

133505 - Mohammed (canonical)

Update: Discussion on possible solution to take place in bugzilla.

129533 - Not planned for this release. Artem to add detail re: use of unique ids, as he recalls it was part of the original conversation.

146535 - related to link source/target bug - tough to describe in the model, without making too complex. No time yet to think through. Documentation would be reasonable here as well.

Linda - without children or containment, generation does not work. Artem: Generator needs to be updated to add passthrough for this case (Submitted 181771).

174503 - Custom templates is easiest approach, currently. Too many places contributing icons already (runtime, emf.edit), so would prefer to avoid a third.

Linda: looking to add icon for semantic elements not in emf.edit (specializations). Will need to think of adding attribute to overrride current, but default to emf.edit

174490 - Not too important, can be worked around (code modification) - better option is to customize template.

174494 - Same type of issue

177797 - After switch to model-to-model transformation, utilizing that trace would be better. Current implementation is quick-n-dirty fix. We'd prefer not to make the current impl. non-experimental so as not to rely on it.

WONTFIX 174498 - .trace will work for now, not sure why it's still open? Linda realized here why trace functionality is "experimental" :) Can close.

New Item: Why does generated code not use Shape style? Artem asked for a bugzilla to be opened to look into this further.