Difference between revisions of "GEF/Contributor Guide"
|Line 42:||Line 42:|
the following format :
of the the be are
, it to a -(
the name of the contributor the be in the .
== Handling of Bugs ==
== Handling of Bugs ==
Revision as of 18:22, 8 March 2012
- 1 Obtaining Source Code
- 2 Setting up the workspace
- 3 Running a headless build locally
- 4 Creating a Contribution
- 5 Commiting code (Committers Only)
- 6 Handling of Bugs
Obtaining Source Code
The complete source code of the GEF project (with the exception of the web-site) is hosted at http://git.eclipse.org:
- The GEF proper code base (Draw2d and GEF (MVC) 3.x as well as Zest 1.x ) can be found in the GEF Git repository
- The GEF4 provisional code base can be found in the GEF4 Git repository.
PLEASE NOTE: Up to now, the code base of the Zest2 provisional component is not hosted within the GEF4 Git repository, but in its own Zest Git repository. It is planned to migrate the code base into the GEF4 Git repository after the Juno release, when the two provisional components are unified (see Bug #372365 for details).
Check out the code (Committers and Contributors) using EGit
To check out the code within your local workspace, perform the following steps:
- Copy the URI of the repository you want to clone (following the links provided above, the URIs are listed under the Clone section). Note that committers will have to use the ssh protocol URI, whereas consumers and contributors are encouraged to use the git protocol URI.
- Clone the Git repository
- Open the Git Repository Exploring Perspective (provided by EGit) within Eclipse, and from the toolbar of the Git Repositories Browser view select to Clone a Git Repository and add the clone to this view.
- If the repository URL was copied to clipboard before, the upcoming Clone Git Repository dialog should already provide the necessary entries for URI, Host, and Repository path, so you may simple forward by pressing Next >.
- Select the branches you want to clone from remote. The master branch is the one used for the current development stream. Development in maintenance releases is performed in respective maintenance branches. After having selected all branches of interest, press Next > to continue.
- Choose a local directory to store the cloned repository (the default will be located under your home directory) and select the Initial branch to check out.
- Checkout the projects
- Right-click the Working directory entry, located under the org.eclipse.gef (resp. org.eclipse.gef4) repository within the Git Repositories Browser view and from the context menu select to Import Projects....
- In the upcoming Import Projects from Git Repository dialog, select to Import existing projects and press Next >.
- Choose the projects you want to import (by default all are selected) and press Finish to conclude.
Setting up the workspace
Set up the Target Platform
A target definition file is provided by the
org.eclipse.gef.target (as well as the
org.eclipse.gef4.target) project. To specify the target platform, simply open the respective target definition (e.g. JUNO_4_2.target) within the Target Editor, let is fully resolve (i.e. wait until the Resolving Target Definition background task has finished and the installable units are listed under the respective Locations), then choose to "Set as Target Platform).
Set up API Tooling
GEF (proper) uses PDE API tooling to guarantee proper handling of version numbering as well as API compatibility, so without definition of an API baseline you will see compile problems after having checked out the code. API-baselines are provided by the
org.eclipse.gef.baseline project. You may define them by going to Preferences -> Plug-in Development -> API Baselines, then choose to select "Add Baseline..." and point to the
plugins sub-folder of an API baseline located in the baselines project (note that the dialog browses the file system instead of the workspace, so you will have to point into the respective folder in your local Git repository).
Running a headless build locally
GEF (as well as GEF4) uses a Maven/Tycho-based build infrastructure. With the Maven Integration installed, the headless build that is executed by a Hudson job can also be executed in the local workspace. Make sure you have checked out all projects listed within the Team Project Set provided above. Then easily run the build by right-clicking the
pom.xml file located within the
org.eclipse.gef.releng project, and selecting 'Run As -> Maven install'. As a result of the build, an update-site will be created in the
target sub-folder of the
Creating a Contribution
Produce a Patch
Fork via GitHub
Commiting code (Committers Only)
When committing code, the following format should be used:
'['<bug-id> | 'NONE' ']' <one-line-summary-or-single-line-commit-message>
 Add support for calculating bezier curve intersections. (CQ 5976)
[NONE] Update target definition to Eclipse SDK 4.2.0.I20120222-0915.
- The bug id of the bug, which is used to track the changes should always be provided, or NONE to indicate that the changes are made without any directly related bug.
- The commit message should be specified using present tense, declaring why the changes were made.
- If a commit message is longer than one short line, it should be formatted to have a short, one-line summary, a blank line, and a wrapped longer description (see .
- If the committer is not the contributor of the changes, the Git author field should be used to specify the full name of the contributor (see Development_Resources/Handling_Git_Contributions). In case the changes were approved by means of a contribution questionnaire, the CQ number should be specified in round brackets after the one line summary.
Handling of Bugs
When working with bugzillas, the following guidelines should be regarded.
Despite selecting a component, a bugzilla may be classified to more precisely specify, what part of the GEF API is concerned. We use categories for this issue, which will be stated as a [<category_name>] prefix within the bugzilla's summary. The list of currently used categories is:
- [TVT] - Translation Verification Tests
When resolving bugzillas, it should be stated how the bug is verified. Preferably this is a JUnit test. Alternatively, the bugzilla will say that the defect can be reproduced in the Logic example and you can demonstrate the fix working in the logic example (or other examples using GEF). If the bug is trivial or obvious and does not require a test, we can just state this in the Bugzilla too.