Notice: this Wiki will be going read only early in 2024 and edits will no longer be possible. Please see: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-shutdown-plan for the plan.
Difference between revisions of "ETrice/Development/Contributions"
< ETrice | Development
(New page: = Handling Contributions = == Sources of information == * http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log#Contributors * http://wiki.eclipse.org/TM_and_RSE_FAQ#How_do_I_sub...) |
(→Example) |
||
(6 intermediate revisions by 2 users not shown) | |||
Line 8: | Line 8: | ||
== Contributor == | == Contributor == | ||
* Pull most recent changes from origin/master | * Pull most recent changes from origin/master | ||
− | * create patch using git format-patch... or Git GUI or TortoiseGit | + | * create patch using git format-patch... or Git GUI or TortoiseGit. See also: http://wiki.eclipse.org/ETrice/Development/Repository#Create_a_Patch_via_Git_Gui |
* attach this patch to bugzilla (don't forget to flag it as patch) | * attach this patch to bugzilla (don't forget to flag it as patch) | ||
Line 19: | Line 19: | ||
* flag the attachment (not the bug!) with iplog+ | * flag the attachment (not the bug!) with iplog+ | ||
* Commit the patch setting the contributor as author and the bug URL in the comment | * Commit the patch setting the contributor as author and the bug URL in the comment | ||
+ | ** <nowiki>example: git commit -a --author="Firstname Name <email@mycompany.com>" -m"applied patch for a really nice feature: https://bugs.eclipse.org/bugs/show_bug.cgi?id=339803"</nowiki> | ||
* Close the bug with a comment mentioning the Git commit (use URL, e.g. http://git.eclipse.org/c/etrice/org.eclipse.etrice.git/commit/?id=c5e939ebca6576a089a4d3c8101f61fd7553371c) | * Close the bug with a comment mentioning the Git commit (use URL, e.g. http://git.eclipse.org/c/etrice/org.eclipse.etrice.git/commit/?id=c5e939ebca6576a089a4d3c8101f61fd7553371c) | ||
* Verify the bug being mentioned correctly in the project's IP log http://www.eclipse.org/projects/ip_log.php?projectid=modeling.mdt.etrice (make sure iplog is flagged on the attachment and the bug is closed) | * Verify the bug being mentioned correctly in the project's IP log http://www.eclipse.org/projects/ip_log.php?projectid=modeling.mdt.etrice (make sure iplog is flagged on the attachment and the bug is closed) | ||
Line 24: | Line 25: | ||
== Example == | == Example == | ||
https://bugs.eclipse.org/bugs/show_bug.cgi?id=337075 | https://bugs.eclipse.org/bugs/show_bug.cgi?id=337075 | ||
+ | |||
+ | == Miscellaneous == | ||
+ | |||
+ | The following Bash command can be used to search missing about.html files (thanks to the MoDisco Wiki pages): | ||
+ | |||
+ | $ find org.eclipse.mdt.modisco* -name build.properties \! -exec grep -sq about.html {} \; -type f -print | ||
[[User:Hrr.protos.de|Hrr.protos.de]] 23:20, 23 February 2011 (UTC) | [[User:Hrr.protos.de|Hrr.protos.de]] 23:20, 23 February 2011 (UTC) |
Revision as of 06:04, 9 May 2011
Contents
Handling Contributions
Sources of information
- http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log#Contributors
- http://wiki.eclipse.org/TM_and_RSE_FAQ#How_do_I_submit_a_contribution_beyond_a_simple_bug_fix.3F
- http://www.eclipse.org/tm/development/committer_howto.php#external_contrib
Contributor
- Pull most recent changes from origin/master
- create patch using git format-patch... or Git GUI or TortoiseGit. See also: http://wiki.eclipse.org/ETrice/Development/Repository#Create_a_Patch_via_Git_Gui
- attach this patch to bugzilla (don't forget to flag it as patch)
Committer
- create a new clone from the eclipse etrice repository for this purpose to avoid interfering changes
- create a new workspace with this contents
- apply the proposed patch using Team > Apply Patch... Make sure to "Apply the patch to the workspace root" and set "Ignore leading path name segments" to 2
- review the patch in the dialog by double clicking file by file and scanning the differences
- verify the patch
- flag the attachment (not the bug!) with iplog+
- Commit the patch setting the contributor as author and the bug URL in the comment
- example: git commit -a --author="Firstname Name <email@mycompany.com>" -m"applied patch for a really nice feature: https://bugs.eclipse.org/bugs/show_bug.cgi?id=339803"
- Close the bug with a comment mentioning the Git commit (use URL, e.g. http://git.eclipse.org/c/etrice/org.eclipse.etrice.git/commit/?id=c5e939ebca6576a089a4d3c8101f61fd7553371c)
- Verify the bug being mentioned correctly in the project's IP log http://www.eclipse.org/projects/ip_log.php?projectid=modeling.mdt.etrice (make sure iplog is flagged on the attachment and the bug is closed)
Example
https://bugs.eclipse.org/bugs/show_bug.cgi?id=337075
Miscellaneous
The following Bash command can be used to search missing about.html files (thanks to the MoDisco Wiki pages):
$ find org.eclipse.mdt.modisco* -name build.properties \! -exec grep -sq about.html {} \; -type f -print
Hrr.protos.de 23:20, 23 February 2011 (UTC)