Difference between revisions of "EDT:How to commit code to EDT"

From Eclipsepedia

Jump to: navigation, search
(Builds)
 
(19 intermediate revisions by one user not shown)
Line 1: Line 1:
'''''All committers must read and understand this page.'''''
+
== Bugzilla bugs are mandatory ==
  
== File encoding ==
+
Every change we commit <span style="color:#FF0000">'''''MUST'''''</span> have a corresponding bug or enhancement in Bugzilla. Be sure to set the bug's Target Milestone correctly.  
Use the UTF-8 encoding for your .java files. You can set UTF-8 as the default for your workspace.
+
  
== CVS change comments are mandatory ==
+
== Git commit messages are mandatory ==
Please, please, please, please, please enter a comment when you commit a change to CVS.  Comments should be concise.  It's best to say why you made the change, as opposed to saying what you changed.
+
  
* Bad: "Fixed a problem."
+
You <span style="color:#FF0000">'''''MUST'''''</span> enter a message when you commit a change to Git. The message <span style="color:#FF0000">'''''MUST'''''</span> include the number of the Bugzilla bug or enhancement.  
* Better: "Added quartsToGallons() on calls to pumpGas()."
+
* Best: "The input to the gas pump must be in gallons, not quarts."
+
  
== Timing ==
+
Commit messages should be concise. It's best to say ''why'' you made the change, as opposed to saying ''what'' you changed.  
Our Nightly builds run at 9 PM Eastern U.S. time. If no files have changed since the last build, a new build won't run.
+
  
== Which files are included in the build ==
+
*Bad: "Bug 12345 - Fixed."
Builds don't simply compile the latest code from CVS.  A special file called a map file identifies the plugins to be built.  There's an entry for each plugin naming the CVS tag for that plugin's code.  (A CVS tag is simply a label on a particular version of a file.The build will include the tagged files from each plugin in the map file.  This means that to get a change into the build, you must commit your file to CVS, put a new tag on it AND all of the other files in the plugin, and update the map file with the new tag.  That's a lot of work, which is why people have written a tool to automate most of the process.  
+
*Better: "Bug 12345 - Added quartsToGallons() on calls to pumpGas()."
 +
*Best: "Bug 12345 - The input to the gas pump must be in gallons, not quarts."
  
The tool is in the org.eclipse.releng.tools plugin.  You can find it by going to http://download.eclipse.org/eclipse/downloads if you use Eclipse 3.6, or http://archive.eclipse.org/eclipse/downloads/index.php if you use an older version of Eclipse.  Click on the link for the release you're using and you'll find org.eclipse.releng.tools at the bottom of the page. 
+
If you want to write more about your changes, do it in Bugzilla.
To install it, unzip it into your dropins folder and restart Eclipse.  
+
  
You need to check out the org.eclipse.edt.releng plugin from CVS, because it contains our map file.  (Releng is short for "release engineering".  Most of the files that control EDT builds are in org.eclipse.edt.releng.)
+
== Links between bugs and fixes are mandatory ==
  
To release a change into the build follow these steps:  
+
When you resolve a bug, you <span style="color:#FF0000">'''''MUST'''''</span> include the ID of your fix's Git commit. If there's more than one commit, include all of their IDs.
  
# Select all plugins that have uncommitted changes, and org.eclipse.edt.releng.
+
The easiest way to find the ID of a commit is with the Git Reflog view, which lists the commits in a particular branch. Double-click on your commit to open it in the Commit Viewer. Right-click on the ID at the top of the Commit Viewer and choose Copy SHA-1.
# Right click (while on any selected plugin) and chose Team->Synchronize with Repository.  This step makes sure you are getting the latest map file and checks for any conflicts before you commit.
+
 
# In the Team Synchronizing perspective, commit your changes and at the same time update changes from other developers into your workspace.  Perform merges if needed.
+
[[Image:copySHA1.png]]
# Go back to the Java Perspective. If there are any errors, correct them and go back to step 1.
+
 
# With the same set of plugins from step 1 still selected, you are now ready to Team-Release them.  Right click (while on any selected plugin) and select Team->Release....  
+
Now you can paste the commit ID into Bugzilla.
# The Release wizard is displayed. Select "Specify the map project you want to use" and select org.eclipse.edt.releng. Click Next.  
+
 
# The wizard displays the list of projects in your workspace that have entries in the map file. In the Project Selection Dialog, verify that the plugins with your changes are checked in the Project Selection dialog.  Click Next.  
+
== File encoding ==
# Specify a release tag for your changes. Your project(s) will be tagged with this tag and the map file will be updated with it as well. The format of a tag should be 'v' followed by a timestamp in YYYYMMDDHHMM format, using 00 to 23 for the hour.  For example, the tag for changes made on December 21st 2012, at 11:59pm is v201212212359.  The timestamp must be in the Eastern U.S. timezone. If you're located elsewhere, go to http://www.timeanddate.com/worldclock/city.html?n=179 for the current time in New York.  
+
 
# The next page allows you to view the changes to the map file. Click Next.
+
We use the UTF-8 encoding for all of our files. Set your workspace's Text File Encoding preference to UTF-8. The preference is on the General > Workspace preference page.
# Enter a commit comment on the last page of the wizard. Click Finish.
+
 
 +
== Builds ==
 +
 
 +
Our Nightly builds run twice a day, at 9 AM and 9 PM Eastern U.S. time. If no changes were made since the last build, then a new build is not produced.
 +
 
 +
Builds for milestones and releases run as needed.
 +
 
 +
== Which files are included in the build ==
  
Note: do not use Team->Release if you're making changes to org.eclipse.edt.releng.  
+
Our builds compile the latest code from the ''master'' branch. There are also a few projects which are not compiled, but are used during the build. For example, we have a set of projects which contain the .egl and .js files for our widgets. The build creates the RUI widget libraries from them.
  
 
[[Category:EDT]]
 
[[Category:EDT]]

Latest revision as of 08:47, 21 August 2012

Contents

[edit] Bugzilla bugs are mandatory

Every change we commit MUST have a corresponding bug or enhancement in Bugzilla. Be sure to set the bug's Target Milestone correctly.

[edit] Git commit messages are mandatory

You MUST enter a message when you commit a change to Git. The message MUST include the number of the Bugzilla bug or enhancement.

Commit messages should be concise. It's best to say why you made the change, as opposed to saying what you changed.

  • Bad: "Bug 12345 - Fixed."
  • Better: "Bug 12345 - Added quartsToGallons() on calls to pumpGas()."
  • Best: "Bug 12345 - The input to the gas pump must be in gallons, not quarts."

If you want to write more about your changes, do it in Bugzilla.

[edit] Links between bugs and fixes are mandatory

When you resolve a bug, you MUST include the ID of your fix's Git commit. If there's more than one commit, include all of their IDs.

The easiest way to find the ID of a commit is with the Git Reflog view, which lists the commits in a particular branch. Double-click on your commit to open it in the Commit Viewer. Right-click on the ID at the top of the Commit Viewer and choose Copy SHA-1.

CopySHA1.png

Now you can paste the commit ID into Bugzilla.

[edit] File encoding

We use the UTF-8 encoding for all of our files. Set your workspace's Text File Encoding preference to UTF-8. The preference is on the General > Workspace preference page.

[edit] Builds

Our Nightly builds run twice a day, at 9 AM and 9 PM Eastern U.S. time. If no changes were made since the last build, then a new build is not produced.

Builds for milestones and releases run as needed.

[edit] Which files are included in the build

Our builds compile the latest code from the master branch. There are also a few projects which are not compiled, but are used during the build. For example, we have a set of projects which contain the .egl and .js files for our widgets. The build creates the RUI widget libraries from them.